You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/21 06:22:47 UTC

[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4604: api: add zone, vm name params in listVmSnapshot response

harikrishna-patnala commented on a change in pull request #4604:
URL: https://github.com/apache/cloudstack/pull/4604#discussion_r561628451



##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -621,11 +621,13 @@ public VMSnapshotResponse createVMSnapshotResponse(VMSnapshot vmSnapshot) {
         vmSnapshotResponse.setDisplayName(vmSnapshot.getDisplayName());
         UserVm vm = ApiDBUtils.findUserVmById(vmSnapshot.getVmId());
         if (vm != null) {
-            vmSnapshotResponse.setVirtualMachineid(vm.getUuid());
+            vmSnapshotResponse.setVirtualMachineId(vm.getUuid());
+            vmSnapshotResponse.setVirtualMachineName(vm.getHostName());

Review comment:
       I think display_name should be first choice, if it is null then we can go with host_name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org