You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by rvs <gi...@git.apache.org> on 2016/01/05 18:58:25 UTC
[GitHub] incubator-hawq pull request: One more pass over clarifying licensi...
GitHub user rvs opened a pull request:
https://github.com/apache/incubator-hawq/pull/243
One more pass over clarifying licensing implications and license tracking in RAT
Please take a look
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rvs/incubator-hawq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #243
----
commit 84b1e30c133f75469f2fdc48e4af17d5e22d955a
Author: Roman Shaposhnik <rv...@apache.org>
Date: 2016-01-04T23:36:29Z
One more pass over clarifying licensing implications and license tracking in RAT
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: One more pass over clarifying licensi...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the pull request:
https://github.com/apache/incubator-hawq/pull/243#issuecomment-169200170
Looks great! Thank you, Roman.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: One more pass over clarifying licensi...
Posted by wangzw <gi...@git.apache.org>.
Github user wangzw commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/243#discussion_r49041485
--- Diff: src/include/catalog/gp_version.in ---
@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
--- End diff --
build error, should use C comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: One more pass over clarifying licensi...
Posted by wangzw <gi...@git.apache.org>.
Github user wangzw commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/243#discussion_r49041450
--- Diff: src/include/nodes/stack.h ---
@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
--- End diff --
build error, should use C comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: One more pass over clarifying licensi...
Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on the pull request:
https://github.com/apache/incubator-hawq/pull/243#issuecomment-169548343
Darn! Looks like my header injection script got tripped up for some reason :-(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: One more pass over clarifying licensi...
Posted by changleicn <gi...@git.apache.org>.
Github user changleicn commented on the pull request:
https://github.com/apache/incubator-hawq/pull/243#issuecomment-169240517
Look good except that it does not have a JIRA number related to this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: One more pass over clarifying licensi...
Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on the pull request:
https://github.com/apache/incubator-hawq/pull/243#issuecomment-169539020
@changleicn ah! Good point about the JIRA. Sorry about not filing one -- will keep that in mind.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: One more pass over clarifying licensi...
Posted by wangzw <gi...@git.apache.org>.
Github user wangzw commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/243#discussion_r49041433
--- Diff: src/include/nodes/plannerconfig.h ---
@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
--- End diff --
build error, should use C comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: One more pass over clarifying licensi...
Posted by rvs <gi...@git.apache.org>.
Github user rvs closed the pull request at:
https://github.com/apache/incubator-hawq/pull/243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---