[jira] [Commented] (LUCENE-8437) CheckIndex should not duplicate SegmentInfos serialization

["Adrien Grand (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563452#comment-16563452 ] 

Adrien Grand commented on LUCENE-8437:
--------------------------------------

Here is a patch.

> CheckIndex should not duplicate SegmentInfos serialization
> ----------------------------------------------------------
>
>                 Key: LUCENE-8437
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8437
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Priority: Major
>         Attachments: LUCENE-8437.patch
>
>
> CheckIndex tries to read the segments file to provide more information about the problem, but it gets almost everything wrong: it reads an int which based on comments and error messages is either the format or the version but this is actually the magic number of the codec header. It looks like this code is about10 years old and hasn't been updated when we added checksums to index files. SegmentInfos does a better job at detecting issues nowadays, so these manual checks can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org