You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/05/17 10:29:48 UTC
[GitHub] [james-project] chibenwa opened a new pull request, #1002: JAMES-3431 Stricter validation for DSN ENVID
chibenwa opened a new pull request, #1002:
URL: https://github.com/apache/james-project/pull/1002
Setting an invalid EndId leads to emails not being
transmissible to third party systems. Stricter validation
fixes this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a diff in pull request #1002: JAMES-3431 Stricter validation for DSN ENVID
Posted by GitBox <gi...@apache.org>.
Arsnael commented on code in PR #1002:
URL: https://github.com/apache/james-project/pull/1002#discussion_r875455689
##########
mailet/api/src/test/java/org/apache/mailet/DsnParametersTest.java:
##########
@@ -128,6 +123,12 @@ void ofShouldThrowOnNullValue() {
.isInstanceOf(NullPointerException.class);
}
+ @Test
+ void ofShouldThrowOnBadValue() {
Review Comment:
Shouldn't we test for `=` and `+` cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1002: JAMES-3431 Stricter validation for DSN ENVID
Posted by GitBox <gi...@apache.org>.
chibenwa merged PR #1002:
URL: https://github.com/apache/james-project/pull/1002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org