You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "clolov (via GitHub)" <gi...@apache.org> on 2026/02/06 13:24:03 UTC
[PR] KAFKA-20130: Move RecordValidationStats to storage module [kafka]
clolov opened a new pull request, #21418:
URL: https://github.com/apache/kafka/pull/21418
Moved to storage and turned into a record for immutability. Removed `add()` because it didn't seem to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20130: Move RecordValidationStats to storage module [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #21418:
URL: https://github.com/apache/kafka/pull/21418#discussion_r2775385281
##########
storage/src/main/java/org/apache/kafka/common/record/RecordValidationStats.java:
##########
@@ -21,52 +21,14 @@
* Record validation covers integrity checks on inbound data (e.g. checksum verification), structural
* validation to make sure that records are well-formed, and conversion between record formats if needed.
*/
-public class RecordValidationStats {
+public record RecordValidationStats(long temporaryMemoryBytes, int numRecordsConverted, long conversionTimeNanos) {
public static final RecordValidationStats EMPTY = new RecordValidationStats();
- private long temporaryMemoryBytes;
- private int numRecordsConverted;
- private long conversionTimeNanos;
-
- public RecordValidationStats(long temporaryMemoryBytes, int numRecordsConverted, long conversionTimeNanos) {
- this.temporaryMemoryBytes = temporaryMemoryBytes;
- this.numRecordsConverted = numRecordsConverted;
- this.conversionTimeNanos = conversionTimeNanos;
- }
-
public RecordValidationStats() {
Review Comment:
Since this constructor is only used by `EMPTY`, can we remove it and just use the main one?
```java
public static final RecordValidationStats EMPTY = new RecordValidationStats(0, 0, 0);
```
##########
storage/src/main/java/org/apache/kafka/common/record/RecordValidationStats.java:
##########
@@ -21,52 +21,14 @@
* Record validation covers integrity checks on inbound data (e.g. checksum verification), structural
* validation to make sure that records are well-formed, and conversion between record formats if needed.
*/
-public class RecordValidationStats {
+public record RecordValidationStats(long temporaryMemoryBytes, int numRecordsConverted, long conversionTimeNanos) {
public static final RecordValidationStats EMPTY = new RecordValidationStats();
- private long temporaryMemoryBytes;
- private int numRecordsConverted;
- private long conversionTimeNanos;
-
- public RecordValidationStats(long temporaryMemoryBytes, int numRecordsConverted, long conversionTimeNanos) {
- this.temporaryMemoryBytes = temporaryMemoryBytes;
- this.numRecordsConverted = numRecordsConverted;
- this.conversionTimeNanos = conversionTimeNanos;
- }
-
public RecordValidationStats() {
this(0, 0, 0);
}
- public void add(RecordValidationStats stats) {
- temporaryMemoryBytes += stats.temporaryMemoryBytes;
- numRecordsConverted += stats.numRecordsConverted;
- conversionTimeNanos += stats.conversionTimeNanos;
- }
-
- /**
- * Returns the number of temporary memory bytes allocated to process the records.
- * This size depends on whether the records need decompression and/or conversion:
- * <ul>
- * <li>Non compressed, no conversion: zero</li>
- * <li>Non compressed, with conversion: size of the converted buffer</li>
- * <li>Compressed, no conversion: size of the original buffer after decompression</li>
- * <li>Compressed, with conversion: size of the original buffer after decompression + size of the converted buffer uncompressed</li>
- * </ul>
- */
- public long temporaryMemoryBytes() {
- return temporaryMemoryBytes;
- }
-
- public int numRecordsConverted() {
- return numRecordsConverted;
- }
-
- public long conversionTimeNanos() {
- return conversionTimeNanos;
- }
-
@Override
public String toString() {
Review Comment:
we could use the generated `toString` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20130: Move RecordValidationStats to storage module [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #21418:
URL: https://github.com/apache/kafka/pull/21418#discussion_r2785128674
##########
storage/src/main/java/org/apache/kafka/common/record/RecordValidationStats.java:
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.common.record;
Review Comment:
Could you move it to `org.apache.kafka.storage.internals.log`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20130: Move RecordValidationStats to storage module [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #21418:
URL: https://github.com/apache/kafka/pull/21418#issuecomment-3880151128
```
Execution failed for task ':storage:compileTestJava'.
> Compilation failed; see the compiler output below.
/home/chia7712/project/kafka/storage/src/test/java/org/apache/kafka/storage/internals/log/LogValidatorTest.java:35: error: cannot find symbol
import org.apache.kafka.common.record.internal.RecordValidationStats;
^
symbol: class RecordValidationStats
location: package org.apache.kafka.common.record.internal
Note: Recompile with -Xlint:unchecked for details.
Note: Some input files use unchecked or unsafe operations.
1 error
```
@clolov please fix the build error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20130: Move RecordValidationStats to storage module [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #21418:
URL: https://github.com/apache/kafka/pull/21418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org