You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "bdemers (via GitHub)" <gi...@apache.org> on 2024/06/18 18:44:36 UTC
[PR] [MNG-8158] Adding name to empty components section in shared site left nav [maven-parent]
bdemers opened a new pull request, #188:
URL: https://github.com/apache/maven-parent/pull/188
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8158] Adding name to empty components section in shared site left nav [maven-parent]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on code in PR #188:
URL: https://github.com/apache/maven-parent/pull/188#discussion_r1644906576
##########
src/site/site.xml:
##########
@@ -77,7 +77,7 @@ under the License.
<item name="Parent POMs" href="https://maven.apache.org/pom/index.html" />
<item name="Plugins" href="https://maven.apache.org/plugins/index.html" />
<item name="Skins" href="https://maven.apache.org/skins/index.html" />
- <item name="">
Review Comment:
I don't think "Components" is the _best_ term because this section also contains "Shared Components", but I couldn't think of a better name.
If anyone has ideas please suggest them!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8158] Adding name to empty components section in shared site left nav [maven-parent]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #188:
URL: https://github.com/apache/maven-parent/pull/188#issuecomment-2176742077
Ideally... I should have created MNG-8158 in MPOM, I don't have access to move it (sorry...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8158] Adding name to empty components section in shared site left nav [maven-parent]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o merged PR #188:
URL: https://github.com/apache/maven-parent/pull/188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org