You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/10/15 00:18:32 UTC

[jira] Created: (LUCENE-2703) multitermquery scoring differences between 3x and trunk

multitermquery scoring differences between 3x and trunk
-------------------------------------------------------

                 Key: LUCENE-2703
                 URL: https://issues.apache.org/jira/browse/LUCENE-2703
             Project: Lucene - Java
          Issue Type: Bug
    Affects Versions: 4.0
            Reporter: Robert Muir
             Fix For: 4.0
         Attachments: LUCENE-2703_test.patch

try this patch with a test, that applies clean to both 3x and trunk, but fails on trunk.

if you modify the test-data-generator to use TopTerms*BoostOnly* rewrite, then it acts like TestFuzzyQuery2, and passes.

So the problem is in TopTermsScoringBooleanRewrite, or BooleanQuery, or somewhere else.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2703) multitermquery scoring differences between 3x and trunk

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921151#action_12921151 ] 

Robert Muir commented on LUCENE-2703:
-------------------------------------

The bug is in TermQuery(Term, int docfreq)

if i change this to:
{noformat}
  public TermQuery(Term t, int docFreq) {
    term = t;
    // this.docFreq = docFreq;
    this.docFreq = -1;
  }
{noformat}

then the test passes

> multitermquery scoring differences between 3x and trunk
> -------------------------------------------------------
>
>                 Key: LUCENE-2703
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2703
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2703_test.patch
>
>
> try this patch with a test, that applies clean to both 3x and trunk, but fails on trunk.
> if you modify the test-data-generator to use TopTerms*BoostOnly* rewrite, then it acts like TestFuzzyQuery2, and passes.
> So the problem is in TopTermsScoringBooleanRewrite, or BooleanQuery, or somewhere else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2703) multitermquery scoring differences between 3x and trunk

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2703:
--------------------------------

    Attachment:     (was: LUCENE-2703_test.patch)

> multitermquery scoring differences between 3x and trunk
> -------------------------------------------------------
>
>                 Key: LUCENE-2703
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2703
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2703.patch, LUCENE-2703_test.patch
>
>
> try this patch with a test, that applies clean to both 3x and trunk, but fails on trunk.
> if you modify the test-data-generator to use TopTerms*BoostOnly* rewrite, then it acts like TestFuzzyQuery2, and passes.
> So the problem is in TopTermsScoringBooleanRewrite, or BooleanQuery, or somewhere else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2703) multitermquery scoring differences between 3x and trunk

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2703:
--------------------------------

    Attachment: LUCENE-2703.patch

> multitermquery scoring differences between 3x and trunk
> -------------------------------------------------------
>
>                 Key: LUCENE-2703
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2703
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2703.patch, LUCENE-2703_test.patch
>
>
> try this patch with a test, that applies clean to both 3x and trunk, but fails on trunk.
> if you modify the test-data-generator to use TopTerms*BoostOnly* rewrite, then it acts like TestFuzzyQuery2, and passes.
> So the problem is in TopTermsScoringBooleanRewrite, or BooleanQuery, or somewhere else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2703) multitermquery scoring differences between 3x and trunk

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921168#action_12921168 ] 

Robert Muir commented on LUCENE-2703:
-------------------------------------

i committed the bugfix, but i will write a good test before resolving the issue.

the "test" i uploaded here is no good, its huge and undebuggable and dependent on the scoring system.


> multitermquery scoring differences between 3x and trunk
> -------------------------------------------------------
>
>                 Key: LUCENE-2703
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2703
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2703.patch, LUCENE-2703_test.patch
>
>
> try this patch with a test, that applies clean to both 3x and trunk, but fails on trunk.
> if you modify the test-data-generator to use TopTerms*BoostOnly* rewrite, then it acts like TestFuzzyQuery2, and passes.
> So the problem is in TopTermsScoringBooleanRewrite, or BooleanQuery, or somewhere else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2703) multitermquery scoring differences between 3x and trunk

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2703:
--------------------------------

    Attachment: LUCENE-2703_test.patch

> multitermquery scoring differences between 3x and trunk
> -------------------------------------------------------
>
>                 Key: LUCENE-2703
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2703
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2703_test.patch
>
>
> try this patch with a test, that applies clean to both 3x and trunk, but fails on trunk.
> if you modify the test-data-generator to use TopTerms*BoostOnly* rewrite, then it acts like TestFuzzyQuery2, and passes.
> So the problem is in TopTermsScoringBooleanRewrite, or BooleanQuery, or somewhere else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2703) multitermquery scoring differences between 3x and trunk

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2703:
--------------------------------

    Attachment: LUCENE-2703_test.patch

here's a patch, really a bad bug, the df was wrong here, but never used until we started
doing these optimizations recently.


> multitermquery scoring differences between 3x and trunk
> -------------------------------------------------------
>
>                 Key: LUCENE-2703
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2703
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2703.patch, LUCENE-2703_test.patch
>
>
> try this patch with a test, that applies clean to both 3x and trunk, but fails on trunk.
> if you modify the test-data-generator to use TopTerms*BoostOnly* rewrite, then it acts like TestFuzzyQuery2, and passes.
> So the problem is in TopTermsScoringBooleanRewrite, or BooleanQuery, or somewhere else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2703) multitermquery scoring differences between 3x and trunk

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921851#action_12921851 ] 

Uwe Schindler commented on LUCENE-2703:
---------------------------------------

Thanks! :-)

> multitermquery scoring differences between 3x and trunk
> -------------------------------------------------------
>
>                 Key: LUCENE-2703
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2703
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2703.patch, LUCENE-2703_test.patch
>
>
> try this patch with a test, that applies clean to both 3x and trunk, but fails on trunk.
> if you modify the test-data-generator to use TopTerms*BoostOnly* rewrite, then it acts like TestFuzzyQuery2, and passes.
> So the problem is in TopTermsScoringBooleanRewrite, or BooleanQuery, or somewhere else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-2703) multitermquery scoring differences between 3x and trunk

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-2703.
---------------------------------

    Resolution: Fixed

Uwe's assert in LUCENE-2690 is better than any test i could add here... it even found a bug in another TermEnum impl.


> multitermquery scoring differences between 3x and trunk
> -------------------------------------------------------
>
>                 Key: LUCENE-2703
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2703
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2703.patch, LUCENE-2703_test.patch
>
>
> try this patch with a test, that applies clean to both 3x and trunk, but fails on trunk.
> if you modify the test-data-generator to use TopTerms*BoostOnly* rewrite, then it acts like TestFuzzyQuery2, and passes.
> So the problem is in TopTermsScoringBooleanRewrite, or BooleanQuery, or somewhere else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org