You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by pavan kumar kolamuri <pa...@gmail.com> on 2014/03/12 12:14:56 UTC
Review Request 19096: FALCON-240 Instance status from CLI on a feed doesn't
give the retention details
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-240
https://issues.apache.org/jira/browse/FALCON-240
Repository: falcon-git
Description
-------
Added lifecycle option in falcon which is used to view the retention details of feed
Diffs
-----
client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c8ce780
client/src/main/java/org/apache/falcon/client/FalconClient.java f008953
common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d
common/src/main/java/org/apache/falcon/hadoop/HadoopClientFactory.java d5fbda8
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java dee77c0
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 5cd7beb
Diff: https://reviews.apache.org/r/19096/diff/
Testing
-------
There are Unit test cases for this.
Thanks,
pavan kumar kolamuri
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by Suhas Vasu <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/#review36912
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/LifeCycle.java
<https://reviews.apache.org/r/19096/#comment68102>
These lifecycle values are only for Feed. We may have lifecycles for process later. It would be better we name the ENUM values appropriately.
common/src/main/java/org/apache/falcon/entity/EntityUtil.java
<https://reviews.apache.org/r/19096/#comment68103>
I don't see this function being used anywhere
common/src/main/java/org/apache/falcon/hadoop/HadoopClientFactory.java
<https://reviews.apache.org/r/19096/#comment68104>
Unnecesary line deletion
- Suhas Vasu
On March 12, 2014, 11:14 a.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19096/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 11:14 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-240
> https://issues.apache.org/jira/browse/FALCON-240
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added lifecycle option in falcon which is used to view the retention details of feed
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c8ce780
> client/src/main/java/org/apache/falcon/client/FalconClient.java f008953
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d
> common/src/main/java/org/apache/falcon/hadoop/HadoopClientFactory.java d5fbda8
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
> hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java dee77c0
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
> test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 5cd7beb
>
> Diff: https://reviews.apache.org/r/19096/diff/
>
>
> Testing
> -------
>
> There are Unit test cases for this.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by Suhas Vasu <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/#review37039
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/19096/#comment68298>
you should print 'lifecycle' rather than 'lifeCycles'
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment68297>
function name is bit misleading, you may want to rename it
- Suhas Vasu
On March 12, 2014, 11:14 a.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19096/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 11:14 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-240
> https://issues.apache.org/jira/browse/FALCON-240
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added lifecycle option in falcon which is used to view the retention details of feed
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c8ce780
> client/src/main/java/org/apache/falcon/client/FalconClient.java f008953
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d
> common/src/main/java/org/apache/falcon/hadoop/HadoopClientFactory.java d5fbda8
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
> hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java dee77c0
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
> test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 5cd7beb
>
> Diff: https://reviews.apache.org/r/19096/diff/
>
>
> Testing
> -------
>
> There are Unit test cases for this.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/#review41123
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/LifeCycle.java
<https://reviews.apache.org/r/19096/#comment74531>
Since tag already contains entity type, entity type can be removed from here
client/src/main/java/org/apache/falcon/LifeCycle.java
<https://reviews.apache.org/r/19096/#comment74532>
fromEntityType() and fromTag() are not required
client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/19096/#comment74533>
This should use valueOf()
common/src/main/java/org/apache/falcon/entity/EntityUtil.java
<https://reviews.apache.org/r/19096/#comment74534>
move to OozieWorkflowEngine
docs/src/site/twiki/FalconCLI.twiki
<https://reviews.apache.org/r/19096/#comment74535>
typo - cane
Mention that its list f lifecycle
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment74536>
There shouldn't be any special handling for retention. AbstractEntityManager should set the default lifecycle if lifecycle is not set. The workflow engine should just check that the tag in the workflow engine is one of the specified lifecycles.
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment74537>
Instead of checking for retention, check if coord name tag contains one of lifecycles
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java
<https://reviews.apache.org/r/19096/#comment74540>
set default values for lifecycle if null
- shwethags
On April 22, 2014, 10:59 a.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19096/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 10:59 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-240
> https://issues.apache.org/jira/browse/FALCON-240
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added lifecycle option in falcon which is used to view the retention details of feed
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4
> client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f
> client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
> docs/src/site/twiki/FalconCLI.twiki 149aaa3
> docs/src/site/twiki/restapi/InstanceKill.twiki eff2893
> docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7
> docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0
> docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569
> docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f
> docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1
> docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5
> docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3
> hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
> test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054
>
> Diff: https://reviews.apache.org/r/19096/diff/
>
>
> Testing
> -------
>
> There are Unit test cases for this.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/
-----------------------------------------------------------
(Updated May 28, 2014, 11:28 a.m.)
Review request for Falcon.
Changes
-------
Added rerun only failed actions and made changes based on comments
Bugs: FALCON-240
https://issues.apache.org/jira/browse/FALCON-240
Repository: falcon-git
Description
-------
Added lifecycle option in falcon which is used to view the retention details of feed
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c51c3c0
client/src/main/java/org/apache/falcon/client/FalconClient.java beecc0f
client/src/main/java/org/apache/falcon/resource/InstancesResult.java da0ccc5
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java c28cb03
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 34192c0
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 3b87469
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 42b4aeb
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java bdf5e1b
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 9471e27
Diff: https://reviews.apache.org/r/19096/diff/
Testing
-------
There are Unit test cases for this.
Thanks,
pavan kumar kolamuri
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/
-----------------------------------------------------------
(Updated May 21, 2014, 8:53 a.m.)
Review request for Falcon.
Bugs: FALCON-240
https://issues.apache.org/jira/browse/FALCON-240
Repository: falcon-git
Description
-------
Added lifecycle option in falcon which is used to view the retention details of feed
Diffs
-----
client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4
client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
docs/src/site/twiki/FalconCLI.twiki 149aaa3
docs/src/site/twiki/restapi/InstanceKill.twiki eff2893
docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7
docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0
docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569
docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f
docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1
docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5
docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054
Diff: https://reviews.apache.org/r/19096/diff/
Testing
-------
There are Unit test cases for this.
Thanks,
pavan kumar kolamuri
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/
-----------------------------------------------------------
(Updated May 21, 2014, 8:53 a.m.)
Review request for Falcon.
Changes
-------
Fixed test cases renaming retention to eviction
Bugs: FALCON-240
https://issues.apache.org/jira/browse/FALCON-240
Repository: falcon-git
Description
-------
Added lifecycle option in falcon which is used to view the retention details of feed
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4
client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
docs/src/site/twiki/FalconCLI.twiki 149aaa3
docs/src/site/twiki/restapi/InstanceKill.twiki eff2893
docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7
docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0
docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569
docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f
docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1
docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5
docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054
Diff: https://reviews.apache.org/r/19096/diff/
Testing
-------
There are Unit test cases for this.
Thanks,
pavan kumar kolamuri
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/#review43472
-----------------------------------------------------------
Ship it!
Ship It!
- shwethags
On May 19, 2014, 12:34 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19096/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 12:34 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-240
> https://issues.apache.org/jira/browse/FALCON-240
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added lifecycle option in falcon which is used to view the retention details of feed
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4
> client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f
> client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
> docs/src/site/twiki/FalconCLI.twiki 149aaa3
> docs/src/site/twiki/restapi/InstanceKill.twiki eff2893
> docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7
> docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0
> docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569
> docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f
> docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1
> docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5
> docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3
> hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
> test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054
>
> Diff: https://reviews.apache.org/r/19096/diff/
>
>
> Testing
> -------
>
> There are Unit test cases for this.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/
-----------------------------------------------------------
(Updated May 19, 2014, 12:34 p.m.)
Review request for Falcon.
Changes
-------
removed from tag function
Bugs: FALCON-240
https://issues.apache.org/jira/browse/FALCON-240
Repository: falcon-git
Description
-------
Added lifecycle option in falcon which is used to view the retention details of feed
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4
client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
docs/src/site/twiki/FalconCLI.twiki 149aaa3
docs/src/site/twiki/restapi/InstanceKill.twiki eff2893
docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7
docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0
docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569
docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f
docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1
docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5
docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054
Diff: https://reviews.apache.org/r/19096/diff/
Testing
-------
There are Unit test cases for this.
Thanks,
pavan kumar kolamuri
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/
-----------------------------------------------------------
(Updated May 8, 2014, 2:32 p.m.)
Review request for Falcon.
Bugs: FALCON-240
https://issues.apache.org/jira/browse/FALCON-240
Repository: falcon-git
Description
-------
Added lifecycle option in falcon which is used to view the retention details of feed
Diffs
-----
client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4
client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
docs/src/site/twiki/FalconCLI.twiki 149aaa3
docs/src/site/twiki/restapi/InstanceKill.twiki eff2893
docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7
docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0
docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569
docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f
docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1
docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5
docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054
Diff: https://reviews.apache.org/r/19096/diff/
Testing
-------
There are Unit test cases for this.
Thanks,
pavan kumar kolamuri
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/
-----------------------------------------------------------
(Updated May 8, 2014, 2:32 p.m.)
Review request for Falcon.
Changes
-------
Changes based on comments
Bugs: FALCON-240
https://issues.apache.org/jira/browse/FALCON-240
Repository: falcon-git
Description
-------
Added lifecycle option in falcon which is used to view the retention details of feed
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4
client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
docs/src/site/twiki/FalconCLI.twiki 149aaa3
docs/src/site/twiki/restapi/InstanceKill.twiki eff2893
docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7
docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0
docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569
docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f
docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1
docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5
docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054
Diff: https://reviews.apache.org/r/19096/diff/
Testing
-------
There are Unit test cases for this.
Thanks,
pavan kumar kolamuri
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/#review42496
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/19096/#comment76286>
type is not required here.
Add lifecycle to type check in FalconClient
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment76287>
rename display.count to displaycount?
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment76289>
call isRetentionCoord(coord) once per coord and store in variable and re-use
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment76290>
should be start<end
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment76291>
rename wfName to coordName
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java
<https://reviews.apache.org/r/19096/#comment76292>
extract entityType from type outside for loop and then use ==
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java
<https://reviews.apache.org/r/19096/#comment76293>
this check should be entity type != lifecycle.tag.type
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java
<https://reviews.apache.org/r/19096/#comment76294>
throw FalconException
The exception should contain the exact lifecycle and type so that its easier for users to understand the exception
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java
<https://reviews.apache.org/r/19096/#comment76295>
duplicate
- shwethags
On May 8, 2014, 10:12 a.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19096/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 10:12 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-240
> https://issues.apache.org/jira/browse/FALCON-240
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added lifecycle option in falcon which is used to view the retention details of feed
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4
> client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f
> client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
> docs/src/site/twiki/FalconCLI.twiki 149aaa3
> docs/src/site/twiki/restapi/InstanceKill.twiki eff2893
> docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7
> docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0
> docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569
> docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f
> docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1
> docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5
> docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3
> hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
> test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054
>
> Diff: https://reviews.apache.org/r/19096/diff/
>
>
> Testing
> -------
>
> There are Unit test cases for this.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/
-----------------------------------------------------------
(Updated May 8, 2014, 10:12 a.m.)
Review request for Falcon.
Changes
-------
Changes based on comments , display retention instances based on property
Bugs: FALCON-240
https://issues.apache.org/jira/browse/FALCON-240
Repository: falcon-git
Description
-------
Added lifecycle option in falcon which is used to view the retention details of feed
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4
client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
docs/src/site/twiki/FalconCLI.twiki 149aaa3
docs/src/site/twiki/restapi/InstanceKill.twiki eff2893
docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7
docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0
docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569
docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f
docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1
docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5
docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054
Diff: https://reviews.apache.org/r/19096/diff/
Testing
-------
There are Unit test cases for this.
Thanks,
pavan kumar kolamuri
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/
-----------------------------------------------------------
(Updated April 22, 2014, 10:59 a.m.)
Review request for Falcon.
Changes
-------
Applied test-patch and modified checkstyles
Bugs: FALCON-240
https://issues.apache.org/jira/browse/FALCON-240
Repository: falcon-git
Description
-------
Added lifecycle option in falcon which is used to view the retention details of feed
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4
client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e
common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
docs/src/site/twiki/FalconCLI.twiki 149aaa3
docs/src/site/twiki/restapi/InstanceKill.twiki eff2893
docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7
docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0
docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569
docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f
docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1
docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5
docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054
Diff: https://reviews.apache.org/r/19096/diff/
Testing
-------
There are Unit test cases for this.
Thanks,
pavan kumar kolamuri
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/
-----------------------------------------------------------
(Updated April 22, 2014, 9:26 a.m.)
Review request for Falcon.
Changes
-------
Changed LifeCycle Enum added EntityType , Update the documentation with Lifecycle option and made changes based on comments.
Bugs: FALCON-240
https://issues.apache.org/jira/browse/FALCON-240
Repository: falcon-git
Description
-------
Added lifecycle option in falcon which is used to view the retention details of feed
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4
client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e
common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
docs/src/site/twiki/FalconCLI.twiki 149aaa3
docs/src/site/twiki/restapi/InstanceKill.twiki eff2893
docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7
docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0
docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569
docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f
docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1
docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5
docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054
Diff: https://reviews.apache.org/r/19096/diff/
Testing
-------
There are Unit test cases for this.
Thanks,
pavan kumar kolamuri
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by Seetharam Venkatesh <ve...@innerzeal.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/#review38681
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/LifeCycle.java
<https://reviews.apache.org/r/19096/#comment70954>
Why is Process execution not a lifecycle?
Also, having the entity type and a tag applicable to each lifecycle makes sense.
Lifecycle(EntityType entityType, Tag tag)
EXECUTION(EntityType.PROCESS, Tag.DEFAULT)
EVICT(EntityType.FEED, Tag.RETENTION)
REPLICATE(EntityType.FEED, Tag.REPLICATION)
client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/19096/#comment70965>
Why would you have multiple life cycles? Option says Lifecycle.
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment70966>
Do not do this, convert to *.
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment70967>
Can you move this into a method for clarity?
Also this needs to be rebased.
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java
<https://reviews.apache.org/r/19096/#comment70969>
Why is this removed? This is necessary.
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java
<https://reviews.apache.org/r/19096/#comment70971>
There is one defined in SchemaHelper, use that.
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java
<https://reviews.apache.org/r/19096/#comment70972>
Is this option optional? if so, what is the default. I do not see a test case for multiple lifecycle options.
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java
<https://reviews.apache.org/r/19096/#comment70975>
There is no update to Documentation. Please update the doc for both CLI and REST API with the new option. Also may be FalconDocumentation.
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java
<https://reviews.apache.org/r/19096/#comment70973>
Please make sure you run the following before uploading the patch.
mvn clean verify -Phadoop-2,test-patch
- Seetharam Venkatesh
On March 26, 2014, 10:07 a.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19096/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 10:07 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-240
> https://issues.apache.org/jira/browse/FALCON-240
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added lifecycle option in falcon which is used to view the retention details of feed
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c8ce780
> client/src/main/java/org/apache/falcon/client/FalconClient.java f008953
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
> hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java dee77c0
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
> test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 5cd7beb
>
> Diff: https://reviews.apache.org/r/19096/diff/
>
>
> Testing
> -------
>
> There are Unit test cases for this.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed
doesn't give the retention details
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/
-----------------------------------------------------------
(Updated March 26, 2014, 10:07 a.m.)
Review request for Falcon.
Changes
-------
Removed unused function
Bugs: FALCON-240
https://issues.apache.org/jira/browse/FALCON-240
Repository: falcon-git
Description
-------
Added lifecycle option in falcon which is used to view the retention details of feed
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c8ce780
client/src/main/java/org/apache/falcon/client/FalconClient.java f008953
common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java f700b8f
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java dee77c0
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 5cd7beb
Diff: https://reviews.apache.org/r/19096/diff/
Testing
-------
There are Unit test cases for this.
Thanks,
pavan kumar kolamuri