You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "rich7420 (via GitHub)" <gi...@apache.org> on 2026/07/05 02:50:57 UTC
[PR] HDDS-15739. Fix ListObjectsV2 continuation-token: wrong XML element name and empty-token handling [ozone]
rich7420 opened a new pull request, #10668:
URL: https://github.com/apache/ozone/pull/10668
## What changes were proposed in this pull request?
ListObjectsV2 has two server-side bugs around the continuation token that make S3 SDK clients fail:
1. **Wrong response element name.** The echoed request continuation token was serialized as
`<continueToken>` instead of AWS's `<ContinuationToken>`. botocore maps response fields by
element name, so `response['ContinuationToken']` was never populated and clients that read it
back hit a `KeyError`.
2. **Empty token not treated as "no token".** An empty `ContinuationToken=''` was passed
(non-null) into `ContinueToken.decodeFromString()`, which found no separator and threw
`InvalidArgument`. AWS treats an empty continuation token as *no token* — return all keys,
`IsTruncated=false`, and echo `''` back.
To align with AWS S3:
- Serialize the response continuation token as `ContinuationToken` (`ListObjectResponse`
`@XmlElement`).
- In `BucketEndpoint`, treat a null/empty `continuation-token` query param as absent (list from
the start, keyed off the decoded token) while still echoing the request value back.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15739
## How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/28727345055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15739. Fix ListObjectsV2 continuation-token: wrong XML element name and empty-token handling [ozone]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl merged PR #10668:
URL: https://github.com/apache/ozone/pull/10668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15739. Fix ListObjectsV2 continuation-token: wrong XML element name and empty-token handling [ozone]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #10668:
URL: https://github.com/apache/ozone/pull/10668#issuecomment-4931589857
Thanks @rich7420 for the patch. Thanks @Russole for reviewing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15739. Fix ListObjectsV2 continuation-token: wrong XML element name and empty-token handling [ozone]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #10668:
URL: https://github.com/apache/ozone/pull/10668#issuecomment-4932226781
@Russole and @smengcl thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org