[GitHub] [hbase] saintstack commented on a change in pull request #974: HBASE-23587 The FSYNC_WAL flag does not work on branch-2.x

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #974: HBASE-23587 The FSYNC_WAL flag does not work on branch-2.x
URL: https://github.com/apache/hbase/pull/974#discussion_r362637637
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java
 ##########
 @@ -347,13 +347,31 @@ private void syncCompleted(AsyncWriter writer, long processedTxid, long startTim
     }
   }
 
+  // find all the sync futures between these two txids to see if we need to issue a hsync, if no
+  // sync futures then just use the default one.
+  private boolean shouldUseHsync(long beginTxid, long endTxid) {
 
 Review comment:
   What about this? This method name is awkward.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services