You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/03 07:17:23 UTC
[GitHub] [hbase] virajjasani commented on a change in pull request #2342: HBASE-24960 reduce invalid subprocedure task
virajjasani commented on a change in pull request #2342:
URL: https://github.com/apache/hbase/pull/2342#discussion_r482756532
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/flush/RegionServerFlushTableProcedureManager.java
##########
@@ -150,6 +150,11 @@ public Subprocedure buildSubprocedure(String table, String family) {
throw new IllegalStateException("Failed to figure out if there is region to flush.", e1);
}
+ if (involvedRegions == null && involvedRegions.isEmpty()) {
Review comment:
It should be `||`, not `&&`
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/RegionServerSnapshotManager.java
##########
@@ -170,6 +170,11 @@ public Subprocedure buildSubprocedure(SnapshotDescription snapshot) {
+ "something has gone awry with the online regions.", e1);
}
+ if (involvedRegions == null && involvedRegions.isEmpty()) {
Review comment:
Same here, `&&` should not be used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org