You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/05 12:20:46 UTC
[GitHub] [airflow] Tonkonozhenko opened a new issue #16812: Add __init__.py to providers dir for mypy compatibility
Tonkonozhenko opened a new issue #16812:
URL: https://github.com/apache/airflow/issues/16812
Currently, I'm running the next command to make mypy working correctly
```
touch /home/airflow/.local/lib/python3.8/site-packages/airflow/providers/__init__.py
```
Could you add this file by default or advice and I'll make PR?
I'm not familiar with the providers' architecture and I don't know where to add this hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #16812: Add __init__.py to providers dir for mypy compatibility
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #16812:
URL: https://github.com/apache/airflow/issues/16812#issuecomment-874080360
`airflow.providers` is a namespace package, and it should not contain a `__init__.py`. Mypy should be able to work with a namespace package, so either we are not configuring Mypy correctly, or this is a bug in Mypy. Either way, the issue should not be resolved by adding a `__init__.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #16812: Add __init__.py to providers dir for mypy compatibility
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #16812:
URL: https://github.com/apache/airflow/issues/16812#issuecomment-874070095
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed issue #16812: Add __init__.py to providers dir for mypy compatibility
Posted by GitBox <gi...@apache.org>.
ashb closed issue #16812:
URL: https://github.com/apache/airflow/issues/16812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #16812: Add __init__.py to providers dir for mypy compatibility
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #16812:
URL: https://github.com/apache/airflow/issues/16812#issuecomment-874101670
This is a known issue and I recommend that you run mypy with a script that has a workaround for this.
https://github.com/apache/airflow/blob/b251d22fffad63124eec5246b80035408b543704/scripts/in_container/run_mypy.sh#L24-L27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #16812: Add __init__.py to providers dir for mypy compatibility
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #16812:
URL: https://github.com/apache/airflow/issues/16812#issuecomment-874070095
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #16812: Add __init__.py to providers dir for mypy compatibility
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #16812:
URL: https://github.com/apache/airflow/issues/16812#issuecomment-874080360
`airflow.providers` is a namespace package, and it should not contain a `__init__.py`. Mypy should be able to work with a namespace package, so either we are not configuring Mypy correctly, or this is a bug in Mypy. Either way, the issue should not be resolved by adding a `__init__.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #16812: Add __init__.py to providers dir for mypy compatibility
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #16812:
URL: https://github.com/apache/airflow/issues/16812#issuecomment-874101670
This is a known issue and I recommend that you run mypy with a script that has a workaround for this.
https://github.com/apache/airflow/blob/b251d22fffad63124eec5246b80035408b543704/scripts/in_container/run_mypy.sh#L24-L27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #16812: Add __init__.py to providers dir for mypy compatibility
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #16812:
URL: https://github.com/apache/airflow/issues/16812#issuecomment-875489909
Close, won't fix. By design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org