[GitHub] [spark] rdblue commented on a change in pull request #24012: [SPARK-26811][SQL] Add capabilities to v2.Table

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #24012: [SPARK-26811][SQL] Add capabilities to v2.Table
URL: https://github.com/apache/spark/pull/24012#discussion_r264763278
 
 

 ##########
 File path: sql/core/src/main/java/org/apache/spark/sql/sources/v2/SupportsRead.java
 ##########
 @@ -25,7 +25,7 @@
  * {@link #newScanBuilder(DataSourceOptions)} that is used to create a scan for batch, micro-batch,
  * or continuous processing.
  */
-interface SupportsRead extends Table {
+public interface SupportsRead extends Table {
 
 Review comment:
   I like having this because it maintains separation between the read/write API and the catalog API. We could update the read and write API later or add a new one by adding a different read trait, without changing how catalogs and tables work. So I think it is worth keeping `SupportsRead` and `SupportsWrite`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org