[jira] [Commented] (YARN-2945) FSLeafQueue should hold lock before and after sorting runnableApps in assignContainer

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240677#comment-14240677 ] 

Hadoop QA commented on YARN-2945:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12686195/YARN-2945.1.patch
  against trunk revision 2e98ad3.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6068//console

This message is automatically generated.

> FSLeafQueue should hold lock before and after sorting runnableApps in assignContainer
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-2945
>                 URL: https://issues.apache.org/jira/browse/YARN-2945
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-2945.1.patch
>
>
> After YARN-2910, assignContainer hold WriteLock while sorting and ReadLock while referencing runnableApps. This can cause interrupted assignment of containers regardless of the policy.
> {code}
>     writeLock.lock();
>     try {
>       Collections.sort(runnableApps, comparator);
>     } finally {
>       writeLock.unlock();
>     }
>     readLock.lock();
>     try {
>       for (FSAppAttempt sched : runnableApps) {
>         if (SchedulerAppUtils.isBlacklisted(sched, node, LOG)) {
>           continue;
>         }
>         assigned = sched.assignContainer(node);
>         if (!assigned.equals(Resources.none())) {
>           break;
>         }
>        }
>     } finally {
>       readLock.unlock();
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)