You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/30 09:11:50 UTC

[GitHub] ffinfo commented on a change in pull request #4396: [WIP][AIRFLOW-3585] - Adding edges to database

ffinfo commented on a change in pull request #4396: [WIP][AIRFLOW-3585] - Adding edges to database
URL: https://github.com/apache/incubator-airflow/pull/4396#discussion_r244528185
 
 

 ##########
 File path: airflow/www/views.py
 ##########
 @@ -1583,13 +1588,10 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm):
             state_token=state_token(dt_nr_dr_data['dr_state']),
             doc_md=doc_md,
             arrange=arrange,
-            operators=sorted(
-                list(set([op.__class__ for op in dag.tasks])),
-                key=lambda x: x.__name__
-            ),
+            operators={v['name']:v for v in ops}.values(),
 
 Review comment:
   not completely, this is a list of dicts and I want only the unique dict names. Not doing this results in duplicates in the legend.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services