You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by Michael Schubert <ms...@pivotal.io> on 2015/09/22 02:39:04 UTC
Commenting on pull requests (was: Fwd: [jira] [Commented] (HAWQ-1)
Remove .p4ignore files from source tree)
Forwarding here to discuss on the list as something of a point of order on
process for us to discuss. These are all open questions in my mind:
* is it ok for people to comment on pull requests? (or rather: to have a
discussion there)
* should people be reminded to please re-post their comment on the JIRA
issue?
* should we drop a link to the JIRA issue on such pull requests to redirect
the conversation?
Amr's comment was highly pertinent as the issue raised was regarding
multiple p4ignore files but the patch only addressed one so letting it go
unanswered or left on the pull request without reflecting it in JIRA seems
bad. Now of course he re-posted his comment on JIRA but for the sake of
this discussion if he had not, I'm wondering how best to handle this.
Have other ASF projects reached opinions on this matter?
Cheers,
Schubert
---------- Forwarded message ----------
From: Amr El-Helw (JIRA) <ji...@apache.org>
Date: Mon, Sep 21, 2015 at 1:08 PM
Subject: [jira] [Commented] (HAWQ-1) Remove .p4ignore files from source tree
To: issues@hawq.incubator.apache.org
[
https://issues.apache.org/jira/browse/HAWQ-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901301#comment-14901301
]
Amr El-Helw commented on HAWQ-1:
--------------------------------
The pull request above only deletes one .p4ignore file. I have seen more
than one such file in the source tree.
(P.S. I already posted a comment in the pull request itself. Only posting
here since I'm not sure which is the proper channel to comment on changes).
> Remove .p4ignore files from source tree
> ---------------------------------------
>
> Key: HAWQ-1
> URL: https://issues.apache.org/jira/browse/HAWQ-1
> Project: Apache HAWQ
> Issue Type: Bug
> Environment: N/A
> Reporter: Gavin Sherry
> Priority: Minor
>
> I notice that there are .p4ignore files in the source tree. These are
irrelevant since HAWQ is hosted in git.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Commenting on pull requests (was: Fwd: [jira] [Commented]
(HAWQ-1) Remove .p4ignore files from source tree)
Posted by CHANG Lei <ch...@gmail.com>.
The coding contribution process that was discussed earlier is now at:
https://cwiki.apache.org/confluence/display/HAWQ/Contributing+to+HAWQ
Let's keep it up-to-date if we want to revise it.
Cheers
Lei
On Tue, Sep 22, 2015 at 11:18 AM, Roman Shaposhnik <ro...@shaposhnik.org>
wrote:
> On Mon, Sep 21, 2015 at 5:39 PM, Michael Schubert <ms...@pivotal.io>
> wrote:
> > Forwarding here to discuss on the list as something of a point of order
> on
> > process for us to discuss. These are all open questions in my mind:
> >
> > * is it ok for people to comment on pull requests? (or rather: to have a
> > discussion there)
>
> Personally, I tend to like peer review tools. At ASF you've got a choice
> of ReviewBoard reviews.apache.org or GH PR reviews. You can always
> roll your own tool too, but I'd rather stay away from that for now.
>
> > * should people be reminded to please re-post their comment on the JIRA
> > issue?
>
> That's a great point. For every pull request that needs to generate
> a commit in the project JIRA needs to be created sooner or later.
> I guess sooner is better ;-)
>
> > * should we drop a link to the JIRA issue on such pull requests to
> redirect
> > the conversation?
> >
> > Amr's comment was highly pertinent as the issue raised was regarding
> > multiple p4ignore files but the patch only addressed one so letting it go
> > unanswered or left on the pull request without reflecting it in JIRA
> seems
> > bad. Now of course he re-posted his comment on JIRA but for the sake of
> > this discussion if he had not, I'm wondering how best to handle this.
> >
> > Have other ASF projects reached opinions on this matter?
>
> Apache Geode (incubating) has a very nicely documented workflow
> that covers all of the above:
> https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
> I suggest you guys take a look at it and start documenting your
> own preferences on the HAWQ wiki.
>
> I also know that Lei has some thoughts on the subject, so perhaps he
> can chime in.
>
> Thanks,
> Roman.
>
Re: Commenting on pull requests (was: Fwd: [jira] [Commented]
(HAWQ-1) Remove .p4ignore files from source tree)
Posted by Roman Shaposhnik <ro...@shaposhnik.org>.
On Mon, Sep 21, 2015 at 5:39 PM, Michael Schubert <ms...@pivotal.io> wrote:
> Forwarding here to discuss on the list as something of a point of order on
> process for us to discuss. These are all open questions in my mind:
>
> * is it ok for people to comment on pull requests? (or rather: to have a
> discussion there)
Personally, I tend to like peer review tools. At ASF you've got a choice
of ReviewBoard reviews.apache.org or GH PR reviews. You can always
roll your own tool too, but I'd rather stay away from that for now.
> * should people be reminded to please re-post their comment on the JIRA
> issue?
That's a great point. For every pull request that needs to generate
a commit in the project JIRA needs to be created sooner or later.
I guess sooner is better ;-)
> * should we drop a link to the JIRA issue on such pull requests to redirect
> the conversation?
>
> Amr's comment was highly pertinent as the issue raised was regarding
> multiple p4ignore files but the patch only addressed one so letting it go
> unanswered or left on the pull request without reflecting it in JIRA seems
> bad. Now of course he re-posted his comment on JIRA but for the sake of
> this discussion if he had not, I'm wondering how best to handle this.
>
> Have other ASF projects reached opinions on this matter?
Apache Geode (incubating) has a very nicely documented workflow
that covers all of the above:
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
I suggest you guys take a look at it and start documenting your
own preferences on the HAWQ wiki.
I also know that Lei has some thoughts on the subject, so perhaps he
can chime in.
Thanks,
Roman.
Re: Commenting on pull requests (was: Fwd: [jira] [Commented] (HAWQ-1) Remove
.p4ignore files from source tree)
Posted by Amr El-Helw <am...@gmail.com>.
Thanks for starting this discussion Schubert.
One thing I can say is that, probably we need to be able to comment on
pull requests, especially if a comment is specific to a particular line
in the pull request (e.g. question about something in the code). It
would be somewhat counter-intuitive if we say that it's not ok to
comment on pull requests, because posting these comments to the jira
ONLY will make it very hard to refer to the line in question.
If there is a mechanism to make those comments generate emails to this
list automatically (similar to how fisheye today generates emails with
every comment that's added), I think that would be ideal...
If not, then perhaps we can limit the comments there to things that are
directly in the pull request, and move any discussions to the jira
(although that line can be blurry sometimes). And either way, it would
be nice to have some sort of notification whenever someone posts a
comment to a pull request...
Also, I would like to hear how other ASF projects handle this.
- Amr
------ Original Message ------
From: "Michael Schubert" <ms...@pivotal.io>
To: dev@hawq.incubator.apache.org
Sent: 9/21/2015 5:39:04 PM
Subject: Commenting on pull requests (was: Fwd: [jira] [Commented]
(HAWQ-1) Remove .p4ignore files from source tree)
>Forwarding here to discuss on the list as something of a point of order
>on
>process for us to discuss. These are all open questions in my mind:
>
>* is it ok for people to comment on pull requests? (or rather: to have
>a
>discussion there)
>* should people be reminded to please re-post their comment on the JIRA
>issue?
>* should we drop a link to the JIRA issue on such pull requests to
>redirect
>the conversation?
>
>Amr's comment was highly pertinent as the issue raised was regarding
>multiple p4ignore files but the patch only addressed one so letting it
>go
>unanswered or left on the pull request without reflecting it in JIRA
>seems
>bad. Now of course he re-posted his comment on JIRA but for the sake of
>this discussion if he had not, I'm wondering how best to handle this.
>
>Have other ASF projects reached opinions on this matter?
>
>Cheers,
>Schubert
>
>---------- Forwarded message ----------
>From: Amr El-Helw (JIRA) <ji...@apache.org>
>Date: Mon, Sep 21, 2015 at 1:08 PM
>Subject: [jira] [Commented] (HAWQ-1) Remove .p4ignore files from source
>tree
>To: issues@hawq.incubator.apache.org
>
>
>
> [
>https://issues.apache.org/jira/browse/HAWQ-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901301#comment-14901301
>]
>
>Amr El-Helw commented on HAWQ-1:
>--------------------------------
>
>The pull request above only deletes one .p4ignore file. I have seen
>more
>than one such file in the source tree.
>
>(P.S. I already posted a comment in the pull request itself. Only
>posting
>here since I'm not sure which is the proper channel to comment on
>changes).
>
>> Remove .p4ignore files from source tree
>> ---------------------------------------
>>
>> Key: HAWQ-1
>> URL: https://issues.apache.org/jira/browse/HAWQ-1
>> Project: Apache HAWQ
>> Issue Type: Bug
>> Environment: N/A
>> Reporter: Gavin Sherry
>> Priority: Minor
>>
>> I notice that there are .p4ignore files in the source tree. These are
>irrelevant since HAWQ is hosted in git.
>
>
>
>--
>This message was sent by Atlassian JIRA
>(v6.3.4#6332)