[GitHub] [hive] mustafaiman commented on a change in pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF

[GitBox <gi...@apache.org>]

mustafaiman commented on a change in pull request #2242:
URL: https://github.com/apache/hive/pull/2242#discussion_r630604192



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapOperator.java
##########
@@ -885,20 +885,7 @@ public void process(Writable value) throws HiveException {
             batchCounter++;
             oneRootOperator.process(deserializerBatch, 0);
 
-            /**
-             * Only reset the current data columns.  Not any data columns defaulted to NULL
-             * because they are not present in the partition, and not partition columns.
-             */
-            for (int c = 0; c < currentDataColumnCount; c++) {
-              ColumnVector colVector = deserializerBatch.cols[c];
-              if (colVector != null) {
-                colVector.reset();
-                colVector.init();
-              }
-            }
-            deserializerBatch.selectedInUse = false;
-            deserializerBatch.size = 0;
-            deserializerBatch.endOfFile = false;
+            deserializerBatch.reset();

Review comment:
       I excluded partition column and rowidentifiercolumn from reset. So this is more like the original code now. It only resets the output columns in addition to original implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org