You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/02/16 11:40:00 UTC
[jira] [Work logged] (HIVE-22890) Repl load fails if table name
contains _function
[ https://issues.apache.org/jira/browse/HIVE-22890?focusedWorklogId=388080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-388080 ]
ASF GitHub Bot logged work on HIVE-22890:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Feb/20 11:39
Start Date: 16/Feb/20 11:39
Worklog Time Spent: 10m
Work Description: maheshk114 commented on pull request #913: HIVE-22890 Fix replication of tables with _functions in the tablename
URL: https://github.com/apache/hive/pull/913#discussion_r379896300
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/events/filesystem/DatabaseEventsIterator.java
##########
@@ -170,7 +170,7 @@ public BootstrapEvent next() {
}
String currentPath = next.toString();
- if (currentPath.contains(FUNCTIONS_ROOT_DIR_NAME)) {
+ if (currentPath.contains(Path.SEPARATOR + FUNCTIONS_ROOT_DIR_NAME)) {
Review comment:
better to append Path.SEPARATOR after _functions for check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 388080)
Time Spent: 20m (was: 10m)
> Repl load fails if table name contains _function
> ------------------------------------------------
>
> Key: HIVE-22890
> URL: https://issues.apache.org/jira/browse/HIVE-22890
> Project: Hive
> Issue Type: Bug
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22890.patch, HIVE-22890.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Repl load tries to load function if table name contains _function. Similarly for the below contants
> {code:java}
> public static final String FUNCTIONS_ROOT_DIR_NAME = "_functions";
> {code}
> The code just checks for contains(FUNCTIONS_ROOT_DIR_NAME). So even if any table or db name contains _functions, it takes the Function Load flow and fails.
>
> {code:java}
> org.apache.hadoop.hive.ql.parse.SemanticException: Invalid pathorg.apache.hadoop.hive.ql.parse.SemanticException: Invalid path at org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:94) ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.executeBootStrapLoad(ReplLoadTask.java:238) ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.execute(ReplLoadTask.java:110) ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:212) ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:103) ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at org.apache.hadoop.hive.ql.exec.TaskRunner.run(TaskRunner.java:82) ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT]Caused by: java.lang.NullPointerException at org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.isFunctionAlreadyLoaded(LoadFunction.java:105) ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:81) ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] ... 5 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)