You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by wk...@apache.org on 2021/11/30 20:07:30 UTC

[trafficserver] branch master updated: Eliminate unused code in LogObject. (#8541)

This is an automated email from the ASF dual-hosted git repository.

wkaras pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 4d430e0  Eliminate unused code in LogObject. (#8541)
4d430e0 is described below

commit 4d430e011b4cf2fc437917ec014c54aa67c98b75
Author: Walt Karas <wk...@verizonmedia.com>
AuthorDate: Tue Nov 30 14:07:22 2021 -0600

    Eliminate unused code in LogObject. (#8541)
---
 proxy/logging/LogObject.cc | 12 ------------
 proxy/logging/LogObject.h  | 11 -----------
 2 files changed, 23 deletions(-)

diff --git a/proxy/logging/LogObject.cc b/proxy/logging/LogObject.cc
index 260a7c8..e8d45c6 100644
--- a/proxy/logging/LogObject.cc
+++ b/proxy/logging/LogObject.cc
@@ -256,18 +256,6 @@ LogObject::add_filter(LogFilter *filter, bool copy)
   m_filter_list.add(filter, copy);
 }
 
-void
-LogObject::set_filter_list(const LogFilterList &list, bool copy)
-{
-  LogFilter *f;
-
-  m_filter_list.clear();
-  for (f = list.first(); f != nullptr; f = list.next(f)) {
-    m_filter_list.add(f, copy);
-  }
-  m_filter_list.set_conjunction(list.does_conjunction());
-}
-
 // we compute the object signature from the fieldlist_str and the printf_str
 // of the LogFormat rather than from the format_str because the format_str
 // is not part of a LogBuffer header
diff --git a/proxy/logging/LogObject.h b/proxy/logging/LogObject.h
index d1d88cf..204c420 100644
--- a/proxy/logging/LogObject.h
+++ b/proxy/logging/LogObject.h
@@ -100,7 +100,6 @@ public:
   ~LogObject() override;
 
   void add_filter(LogFilter *filter, bool copy = true);
-  void set_filter_list(const LogFilterList &list, bool copy = true);
 
   inline void
   set_fmt_timestamps()
@@ -124,16 +123,6 @@ public:
 
   unsigned roll_files(long time_now = 0);
 
-  inline int
-  add_to_flush_queue(LogBuffer *buffer)
-  {
-    int idx = m_buffer_manager_idx++ % m_flush_threads;
-
-    m_buffer_manager[idx].add_to_flush_queue(buffer);
-
-    return idx;
-  }
-
   inline size_t
   preproc_buffers(int idx = -1)
   {