You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/07 06:33:58 UTC
[GitHub] [incubator-doris] gaodayue opened a new pull request #3269:
Optimize performance of TxnManager::build_expire_txn_map
gaodayue opened a new pull request #3269: Optimize performance of TxnManager::build_expire_txn_map
URL: https://github.com/apache/incubator-doris/pull/3269
It's not possible to insert duplicated transaction ids for a specific tablet, therefore we could use `map<TabletInfo, vector<int64_t>>` instead of `map<TabletInfo, set<int64_t>>` for expire_txn_map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] gaodayue commented on issue #3269: Optimize
performance of TxnManager::build_expire_txn_map
Posted by GitBox <gi...@apache.org>.
gaodayue commented on issue #3269: Optimize performance of TxnManager::build_expire_txn_map
URL: https://github.com/apache/incubator-doris/pull/3269#issuecomment-610223198
> By the way, could you please add some label to this PR, like performance and storage engine?
Sure, added.
> And do you have any improvement data resulted from this PR?
Not yet. The background for this PR is that we independently found and solved the issue of #2214 which could decrease the tablet report time from 30s to 1s. When submitting the PR, I found that it's already addressed by #2215. So I compared our patch with that PR and found that our version which use vector instead of set may be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #3269: Optimize
performance of TxnManager::build_expire_txn_map
Posted by GitBox <gi...@apache.org>.
imay merged pull request #3269: Optimize performance of TxnManager::build_expire_txn_map
URL: https://github.com/apache/incubator-doris/pull/3269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] gaodayue edited a comment on issue #3269:
Optimize performance of TxnManager::build_expire_txn_map
Posted by GitBox <gi...@apache.org>.
gaodayue edited a comment on issue #3269: Optimize performance of TxnManager::build_expire_txn_map
URL: https://github.com/apache/incubator-doris/pull/3269#issuecomment-610223198
> By the way, could you please add some label to this PR, like performance and storage engine?
Sure, added.
> And do you have any improvement data resulted from this PR?
Not yet. The background for this PR is that we independently found and solved the issue of #2214 which could decrease the tablet report time from 30s to 1s. When submitting the PR, I found that it's already addressed by #2215. So I compared our patch with that PR and found that our version which use vector instead of set may be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org