You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/08 02:40:38 UTC
[kudu-CR] KUDU-1420. client: remove unimplemented ApplyAsync() method
Hello Adar Dembo, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4332
to review the following change.
Change subject: KUDU-1420. client: remove unimplemented ApplyAsync() method
......................................................................
KUDU-1420. client: remove unimplemented ApplyAsync() method
This was never implemented, and doesn't seem to have value as
documentation of a non-existent method.
Change-Id: If5006994039d13055a71235ebf4aa547329d35aa
---
M src/kudu/client/client.h
1 file changed, 0 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/4332/1
--
To view, visit http://gerrit.cloudera.org:8080/4332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5006994039d13055a71235ebf4aa547329d35aa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-1420. client: remove unimplemented ApplyAsync() method
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1420. client: remove unimplemented ApplyAsync() method
......................................................................
KUDU-1420. client: remove unimplemented ApplyAsync() method
This was never implemented, and doesn't seem to have value as
documentation of a non-existent method.
Change-Id: If5006994039d13055a71235ebf4aa547329d35aa
Reviewed-on: http://gerrit.cloudera.org:8080/4332
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/client/client.h
1 file changed, 0 insertions(+), 17 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5006994039d13055a71235ebf4aa547329d35aa
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1420. client: remove unimplemented ApplyAsync() method
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1420. client: remove unimplemented ApplyAsync() method
......................................................................
Patch Set 1:
OK, I'll commit this removal for now, can always add it back with the magic of source control.
--
To view, visit http://gerrit.cloudera.org:8080/4332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5006994039d13055a71235ebf4aa547329d35aa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1420. client: remove unimplemented ApplyAsync() method
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1420. client: remove unimplemented ApplyAsync() method
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3277/
--
To view, visit http://gerrit.cloudera.org:8080/4332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5006994039d13055a71235ebf4aa547329d35aa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1420. client: remove unimplemented ApplyAsync() method
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1420. client: remove unimplemented ApplyAsync() method
......................................................................
Patch Set 1: Code-Review+2
Alexey may or may not have started working on this. We talked about it a bit while he was working on AUTO_FLUSH_BACKGROUND.
--
To view, visit http://gerrit.cloudera.org:8080/4332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5006994039d13055a71235ebf4aa547329d35aa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No