You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/10/18 14:42:59 UTC
[GitHub] [orc] coderex2522 opened a new pull request, #1282: ORC-1288: [C++] fix the bug that invalid memory freeing with zlib compression.
coderex2522 opened a new pull request, #1282:
URL: https://github.com/apache/orc/pull/1282
### What changes were proposed in this pull request?
This bug can be triggered when writing a orc file that contains multiple stripes, and each stripe contains columns with no null values. This is mainly caused by the fact that the relevant member variables in CompressionStream have not been reset.
### Why are the changes needed?
The patch can fix the bug about invalid memory freeing with multiple compression kinds.
### How was this patch tested?
Added new UT WriterTest.suppressPresentStreamWithCompressionKinds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] coderex2522 commented on a diff in pull request #1282: ORC-1288: [C++] fix the bug that invalid memory freeing with zlib compression.
Posted by GitBox <gi...@apache.org>.
coderex2522 commented on code in PR #1282:
URL: https://github.com/apache/orc/pull/1282#discussion_r999007745
##########
c++/test/TestWriter.cc:
##########
@@ -1996,5 +1996,49 @@ namespace orc {
}
}
+ void testSuppressPresentStream(orc::CompressionKind kind) {
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1282: ORC-1288: [C++] fix the bug that invalid memory freeing with zlib compression.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1282:
URL: https://github.com/apache/orc/pull/1282#issuecomment-1284408880
cc @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1282: ORC-1288: [C++] fix the bug that invalid memory freeing with zlib compression.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1282: ORC-1288: [C++] fix the bug that invalid memory freeing with zlib compression.
URL: https://github.com/apache/orc/pull/1282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1282: ORC-1288: [C++] fix the bug that invalid memory freeing with zlib compression.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1282:
URL: https://github.com/apache/orc/pull/1282#issuecomment-1284408754
Merged to main/1.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on a diff in pull request #1282: ORC-1288: [C++] fix the bug that invalid memory freeing with zlib compression.
Posted by GitBox <gi...@apache.org>.
wgtmac commented on code in PR #1282:
URL: https://github.com/apache/orc/pull/1282#discussion_r998869772
##########
c++/test/TestWriter.cc:
##########
@@ -1996,5 +1996,49 @@ namespace orc {
}
}
+ void testSuppressPresentStream(orc::CompressionKind kind) {
Review Comment:
nit: add some comment to explain why we have added the case since it does not have any ASSERT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1282: ORC-1288: [C++] fix the bug that invalid memory freeing with zlib compression.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1282:
URL: https://github.com/apache/orc/pull/1282#issuecomment-1284411872
cc @noirello since he is the issue reporter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] noirello commented on pull request #1282: ORC-1288: [C++] fix the bug that invalid memory freeing with zlib compression.
Posted by GitBox <gi...@apache.org>.
noirello commented on PR #1282:
URL: https://github.com/apache/orc/pull/1282#issuecomment-1284426325
Excellent. Thank you, guys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org