[GitHub] [spark] cloud-fan commented on a change in pull request #30329: [SPARK-33420][SQL] Fix BroadCastJoin failure when keys on join side has cast from DateTyte to String

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #30329:
URL: https://github.com/apache/spark/pull/30329#discussion_r522189703



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -110,6 +110,7 @@ object Cast {
     case (StringType, TimestampType | DateType) => true
     case (TimestampType | DateType, StringType) => true
     case (DateType, TimestampType) => true
+    case (DateType, StringType) => true

Review comment:
       Yea it's already covered by L111. We should close this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org