You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by em...@apache.org on 2019/06/04 03:57:18 UTC

[arrow] branch master updated: ARROW-5491: [C++] Remove unecessary semicolons following MACRO definitions

This is an automated email from the ASF dual-hosted git repository.

emkornfield pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 40f876b  ARROW-5491: [C++] Remove unecessary semicolons following MACRO definitions
40f876b is described below

commit 40f876bbb3ff4699394a80424f28b019d695b079
Author: Brian Hulette <bh...@google.com>
AuthorDate: Mon Jun 3 20:56:21 2019 -0700

    ARROW-5491: [C++] Remove unecessary semicolons following MACRO definitions
    
    To be honest I'm not sure how these semicolons aren't causing an issue currently. Either way, removing them seems like a noop and improves clarity in my opinion.
    
    Author: Brian Hulette <bh...@google.com>
    
    Closes #4422 from TheNeuralBit/semicolon and squashes the following commits:
    
    af8c0a1e8 <Brian Hulette> remove semicolons after macro definitions
---
 cpp/src/arrow/ipc/json-test.cc       | 2 +-
 cpp/src/arrow/ipc/read-write-test.cc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpp/src/arrow/ipc/json-test.cc b/cpp/src/arrow/ipc/json-test.cc
index 1b48484..b21e430 100644
--- a/cpp/src/arrow/ipc/json-test.cc
+++ b/cpp/src/arrow/ipc/json-test.cc
@@ -387,7 +387,7 @@ TEST(TestJsonFileReadWrite, MinimalFormatExample) {
                     &MakeZeroLengthRecordBatch, &MakeDeeplyNestedList,             \
                     &MakeStringTypesRecordBatchWithNulls, &MakeStruct, &MakeUnion, \
                     &MakeDates, &MakeTimestamps, &MakeTimes, &MakeFWBinary,        \
-                    &MakeDecimal, &MakeDictionary, &MakeIntervals);
+                    &MakeDecimal, &MakeDictionary, &MakeIntervals)
 
 class TestJsonRoundTrip : public ::testing::TestWithParam<MakeRecordBatch*> {
  public:
diff --git a/cpp/src/arrow/ipc/read-write-test.cc b/cpp/src/arrow/ipc/read-write-test.cc
index c21a547..96ead3d 100644
--- a/cpp/src/arrow/ipc/read-write-test.cc
+++ b/cpp/src/arrow/ipc/read-write-test.cc
@@ -218,7 +218,7 @@ TEST_F(TestSchemaMetadata, KeyValueMetadata) {
                     &MakeStringTypesRecordBatchWithNulls, &MakeStruct, &MakeUnion,      \
                     &MakeDictionary, &MakeDates, &MakeTimestamps, &MakeTimes,           \
                     &MakeFWBinary, &MakeNull, &MakeDecimal, &MakeBooleanBatch,          \
-                    &MakeIntervals);
+                    &MakeIntervals)
 
 static int g_file_number = 0;