You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/11 06:18:03 UTC

[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #3045: [Improve][Core][Exceptiom Management] Add Exception Management API

EricJoy2048 commented on PR #3045:
URL: https://github.com/apache/incubator-seatunnel/pull/3045#issuecomment-1274139646

   > > > I have a different point of view, why don't we directly inherit SeaTunnelException to implement different types of Exception, but use enumeration to determine the Exception type? What is the use of Code for users? And it is impossible to manage all Exception through CommonErrorCode, and some Exceptions will use CommonErrorCode, and some will not be used.
   > > 
   > > 
   > > +1. It's better to use a different implementation.
   > 
   > So if a connector has more than 10 types exceptions, do we need define more than 10 classes to display those? It's not a good option. More More fine-grained exception I want to show what should I do?
   
   That's what I'm worried about.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org