You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/01/30 03:54:59 UTC
[GitHub] vogievetsky commented on a change in pull request #6923: Adding a
Unified web console.
vogievetsky commented on a change in pull request #6923: Adding a Unified web console.
URL: https://github.com/apache/incubator-druid/pull/6923#discussion_r252108923
##########
File path: pom.xml
##########
@@ -1444,18 +1463,33 @@
<pattern>GPL v2 or BSD 3 point style</pattern>
</patterns>
</license>
+ <license implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
+ <licenseFamilyCategory>Font Awesome</licenseFamilyCategory>
+ <licenseFamilyName>Font Awesome</licenseFamilyName>
+ <notes></notes>
+ <patterns>
+ <pattern>Font Awesome 4.2.0 by @davegandy - http://fontawesome.io - @fontawesome</pattern>
Review comment:
No, Font Awesome is being used by the [legacy coordinator console](https://github.com/druid-io/druid-console/blob/master/bower.json#L19). It was copied here without changes. It is out of scope for this project to make any kind of modification to the code of the original coordinator console
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org