[jira] [Commented] (HBASE-16096) Replication keeps accumulating znodes

["Joseph (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357985#comment-15357985 ] 

Joseph commented on HBASE-16096:
--------------------------------

I am not sure about the changes I made in the ReplicationPeerZkImpl, but I think it makes sense to disable the peer on znode-deletion. It is probably redundant with other peer deletion handlers, but also allows replication to a peer to stop immediately when the peer znode is deleted. What do you think [~ashu210890]?

> Replication keeps accumulating znodes
> -------------------------------------
>
>                 Key: HBASE-16096
>                 URL: https://issues.apache.org/jira/browse/HBASE-16096
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 2.0.0, 1.2.0, 1.3.0
>            Reporter: Ashu Pachauri
>            Assignee: Joseph
>         Attachments: HBASE-16096.patch
>
>
> If there is an error while creating the replication source on adding the peer, the source if not added to the in memory list of sources but the replication peer is. 
> However, in such a scenario, when you remove the peer, it is deleted from zookeeper successfully but for removing the in memory list of peers, we wait for the corresponding sources to get deleted (which as we said don't exist because of error creating the source). 
> The problem here is the ordering of operations for adding/removing source and peer. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)