You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/02 09:13:17 UTC
[GitHub] [airflow] potiuk opened a new pull request #15153: Merges quarantined tests into single job
potiuk opened a new pull request #15153:
URL: https://github.com/apache/airflow/pull/15153
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15153: Merges quarantined tests into single job
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15153:
URL: https://github.com/apache/airflow/pull/15153#issuecomment-813084127
This is yet another improvement in speedup/less number of jobs. I tested it with my personal account for "Public runners" and it works nicely: https://github.com/potiuk/airflow/runs/2264495705?check_suite_focus=true#step:9:33 All three quarantined tests are run sequentially there and take 25 minutes where previosly it was three jobs x 9 minutes, so we save a bit but also we save on the overhead connected with the number of jobs needed. And all the other tests are ~ 27 minutes so this one is not longer than the others.
In 'self-hosted' runners, the saving is huge. Instead of 3x7.30 minutes we have 1x 10 minutes which is > 60% improvemente and 13 minutes of build time less.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15153: Merges quarantined tests into single job
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15153:
URL: https://github.com/apache/airflow/pull/15153#issuecomment-813376259
That's even nicer. The quarantined tests worked when combined on my "Public Runners" and they run in ~ 15 - 25 minutes (some quarantined tests hangs for longer sometimes). https://github.com/potiuk/airflow/runs/2266678133?check_suite_focus=true here as an example . So I think we are good to go with this optimisation - yet another 'cost + time saving' step forward.
Looking forward to merge this one (BTW. I have merging K8S tests in the works as well as the ultimate step).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #15153: Merges quarantined tests into single job
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #15153:
URL: https://github.com/apache/airflow/pull/15153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15153: Merges quarantined tests into single job
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15153:
URL: https://github.com/apache/airflow/pull/15153#issuecomment-813510999
I have two more simplification /speedups coming on top of this one, so it would be good to merge that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15153: Merges quarantined tests into single job
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15153:
URL: https://github.com/apache/airflow/pull/15153#issuecomment-812879595
[The Workflow run](https://github.com/apache/airflow/actions/runs/714561502) is cancelling this PR. Building image for the PR has been cancelled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org