You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Nick Dekker (Jira)" <ji...@apache.org> on 2021/03/23 15:47:00 UTC

[jira] [Comment Edited] (KAFKA-12420) Kafka network Selector class has many constructors; use a Builder pattern instead

    [ https://issues.apache.org/jira/browse/KAFKA-12420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307171#comment-17307171 ] 

Nick Dekker edited comment on KAFKA-12420 at 3/23/21, 3:46 PM:
---------------------------------------------------------------

Seems like a straightforward implementation. We have created a PR here:
 [https://github.com/apache/kafka/pull/10385|https://github.com/apache/kafka/pull/10382]

A validation and a second opinion would be appreciated.


was (Author: ikdekker):
Seems like a straightforward implementation. We have created a PR here:
[https://github.com/apache/kafka/pull/10382]



A validation and a second opinion would be appreciated.

> Kafka network Selector class has many constructors; use a Builder pattern instead
> ---------------------------------------------------------------------------------
>
>                 Key: KAFKA-12420
>                 URL: https://issues.apache.org/jira/browse/KAFKA-12420
>             Project: Kafka
>          Issue Type: Improvement
>          Components: network
>    Affects Versions: 2.7.0
>            Reporter: Steve Rodrigues
>            Assignee: Steve Rodrigues
>            Priority: Minor
>
> The Kafka network Selector has a myriad of constructor parameters and to deal with its multiple use cases this class has 6 distinct constructors taking up to 12 parameters (or various combinations thereof). The proposal for this small task is to have a builder pattern to consolidate to a simple path going forward.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)