(ossie) branch main updated: fix(honeydew): name the Ossie document in the missing-name error (#420)

[jb...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jbonofre pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ossie.git


The following commit(s) were added to refs/heads/main by this push:
     new 529f3093 fix(honeydew): name the Ossie document in the missing-name error (#420)
529f3093 is described below

commit 529f3093d250784ec3f24b4149c52693f0888a98
Author: Baruch Oxman <ba...@honeydew.ai>
AuthorDate: Sun Sep 27 13:47:16 2026 +0100

    fix(honeydew): name the Ossie document in the missing-name error (#420)
    
    Rebased onto main after #396 migrated the converter to flat documents;
    that change already covers the flat read/write, the root dialects/vendors
    guard, and the legacy wrapper rejection. What remains: the missing-name
    error refers to the Ossie document rather than a semantic model, and its
    test asserts the message on an otherwise-valid flat document.
    
    Co-authored-by: Claude Opus 5.5 (1M context) <no...@anthropic.com>
---
 converters/honeydew/src/ossie_honeydew/converter.py        | 2 +-
 converters/honeydew/tests/test_ossie_honeydew_converter.py | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/converters/honeydew/src/ossie_honeydew/converter.py b/converters/honeydew/src/ossie_honeydew/converter.py
index 3ead23d1..0a14ca16 100644
--- a/converters/honeydew/src/ossie_honeydew/converter.py
+++ b/converters/honeydew/src/ossie_honeydew/converter.py
@@ -112,7 +112,7 @@ def convert_ossie_to_honeydew(ossie_yaml_str: str) -> dict[str, str]:
 def _model_to_files(sm: dict[str, Any]) -> dict[str, str]:
     name = sm.get("name")
     if not name:
-        raise HoneydewConversionError("Missing 'name' in semantic model")
+        raise HoneydewConversionError("Missing 'name' in Ossie document")
 
     files: dict[str, str] = {}
 
diff --git a/converters/honeydew/tests/test_ossie_honeydew_converter.py b/converters/honeydew/tests/test_ossie_honeydew_converter.py
index 40a2d4ac..fd71555f 100644
--- a/converters/honeydew/tests/test_ossie_honeydew_converter.py
+++ b/converters/honeydew/tests/test_ossie_honeydew_converter.py
@@ -599,9 +599,9 @@ def test_ossie_to_honeydew_invalid_version_raises():
         convert_ossie_to_honeydew("version: '9.9.9'\nname: m\n")
 
 
-def test_ossie_to_honeydew_missing_model_name_raises():
-    with pytest.raises(HoneydewConversionError):
-        convert_ossie_to_honeydew(f"version: '{OSSIE_VERSION}'\n")
+def test_ossie_to_honeydew_missing_name_raises():
+    with pytest.raises(HoneydewConversionError, match="Missing 'name'"):
+        convert_ossie_to_honeydew(f"version: '{OSSIE_VERSION}'\ndatasets: []\n")
 
 
 @pytest.mark.parametrize(