You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by sn...@apache.org on 2015/10/17 12:36:32 UTC

[1/4] cassandra git commit: AssertionError: attempted to delete non-existing file CommitLog

Repository: cassandra
Updated Branches:
  refs/heads/trunk 3c4a3bcd8 -> 5dd2247dd


AssertionError: attempted to delete non-existing file CommitLog

patch by Vovodroid; reviewed by Robert Stupp for CASSANDRA-10377


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/27c80117
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/27c80117
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/27c80117

Branch: refs/heads/trunk
Commit: 27c80117d2ff62acbecc0887ca851bb541b2d830
Parents: f587397
Author: Vovodroid <vo...@gmail.com>
Authored: Sat Oct 17 11:37:47 2015 +0200
Committer: Robert Stupp <sn...@snazy.de>
Committed: Sat Oct 17 11:37:47 2015 +0200

----------------------------------------------------------------------
 CHANGES.txt                                                    | 1 +
 .../apache/cassandra/db/commitlog/CommitLogSegmentManager.java | 6 +++++-
 2 files changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/27c80117/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 68b44ed..7358689 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.1.12
+ * AssertionError: attempted to delete non-existing file CommitLog (CASSANDRA-10377)
  * Merge range tombstones during compaction (CASSANDRA-7953)
  * (cqlsh) Distinguish negative and positive infinity in output (CASSANDRA-10523)
  * (cqlsh) allow custom time_format for COPY TO (CASSANDRA-8970)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/27c80117/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java b/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
index ba37576..9310d67 100644
--- a/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
+++ b/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
@@ -347,7 +347,11 @@ public class CommitLogSegmentManager
     void recycleSegment(final CommitLogSegment segment)
     {
         boolean archiveSuccess = CommitLog.instance.archiver.maybeWaitForArchiving(segment.getName());
-        activeSegments.remove(segment);
+        if (!activeSegments.remove(segment))
+        {
+            logger.warn("segment {} not found in activeSegments queue", segment);
+            return;
+        }
         if (!archiveSuccess)
         {
             // if archiving (command) was not successful then leave the file alone. don't delete or recycle.


[4/4] cassandra git commit: Merge branch 'cassandra-3.0' into trunk

Posted by sn...@apache.org.
Merge branch 'cassandra-3.0' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/5dd2247d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/5dd2247d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/5dd2247d

Branch: refs/heads/trunk
Commit: 5dd2247dd8e2bcd4ccff04c9d3b236b354184c46
Parents: 3c4a3bc 10c65d4
Author: Robert Stupp <sn...@snazy.de>
Authored: Sat Oct 17 11:40:12 2015 +0200
Committer: Robert Stupp <sn...@snazy.de>
Committed: Sat Oct 17 11:40:12 2015 +0200

----------------------------------------------------------------------
 CHANGES.txt                                             |  5 +++++
 .../cassandra/db/commitlog/CommitLogSegmentManager.java | 12 +++++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/5dd2247d/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index 725cc9f,9b86ebd..67df8c2
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,8 -1,8 +1,13 @@@
 +3.2
 + * Abort in-progress queries that time out (CASSANDRA-7392)
 + * Add transparent data encryption core classes (CASSANDRA-9945)
 +
 +
+ 3.0
+ Merged from 2.1:
+  * AssertionError: attempted to delete non-existing file CommitLog (CASSANDRA-10377)
+ 
+ 
  3.0-rc2
   * Fix SELECT DISTINCT queries between 2.2.2 nodes and 3.0 nodes (CASSANDRA-10473)
   * Remove circular references in SegmentedFile (CASSANDRA-10543)


[2/4] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2

Posted by sn...@apache.org.
Merge branch 'cassandra-2.1' into cassandra-2.2


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/20ce2cf3
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/20ce2cf3
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/20ce2cf3

Branch: refs/heads/trunk
Commit: 20ce2cf3564a113b6bcd9c4bc761dfeac37349a6
Parents: f497c13 27c8011
Author: Robert Stupp <sn...@snazy.de>
Authored: Sat Oct 17 11:38:27 2015 +0200
Committer: Robert Stupp <sn...@snazy.de>
Committed: Sat Oct 17 11:38:27 2015 +0200

----------------------------------------------------------------------
 CHANGES.txt                                             |  1 +
 .../cassandra/db/commitlog/CommitLogSegmentManager.java | 12 +++++++++---
 2 files changed, 10 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/20ce2cf3/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index 632e262,7358689..889438f
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,7 -1,6 +1,8 @@@
 -2.1.12
 +2.2.4
 + * Deprecate Pig support (CASSANDRA-10542)
 + * Reduce contention getting instances of CompositeType (CASSANDRA-10433)
 +Merged from 2.1:
+  * AssertionError: attempted to delete non-existing file CommitLog (CASSANDRA-10377)
 - * Merge range tombstones during compaction (CASSANDRA-7953)
   * (cqlsh) Distinguish negative and positive infinity in output (CASSANDRA-10523)
   * (cqlsh) allow custom time_format for COPY TO (CASSANDRA-8970)
   * Don't allow startup if the node's rack has changed (CASSANDRA-10242)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/20ce2cf3/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
----------------------------------------------------------------------
diff --cc src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
index f71bb1b,9310d67..2ca2fea
--- a/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
+++ b/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
@@@ -339,10 -346,32 +339,16 @@@ public class CommitLogSegmentManage
       */
      void recycleSegment(final CommitLogSegment segment)
      {
 -        boolean archiveSuccess = CommitLog.instance.archiver.maybeWaitForArchiving(segment.getName());
 -        if (!activeSegments.remove(segment))
 -        {
 -            logger.warn("segment {} not found in activeSegments queue", segment);
 -            return;
 -        }
 -        if (!archiveSuccess)
 +        boolean archiveSuccess = commitLog.archiver.maybeWaitForArchiving(segment.getName());
-         activeSegments.remove(segment);
-         // if archiving (command) was not successful then leave the file alone. don't delete or recycle.
-         discardSegment(segment, archiveSuccess);
++        if (activeSegments.remove(segment))
+         {
+             // if archiving (command) was not successful then leave the file alone. don't delete or recycle.
 -            discardSegment(segment, false);
 -            return;
++            discardSegment(segment, archiveSuccess);
+         }
 -        if (isCapExceeded() || !DatabaseDescriptor.getCommitLogSegmentRecyclingEnabled())
++        else
+         {
 -            discardSegment(segment, true);
 -            return;
++            logger.warn("segment {} not found in activeSegments queue", segment);
+         }
 -
 -        logger.debug("Recycling {}", segment);
 -        segmentManagementTasks.add(new Callable<CommitLogSegment>()
 -        {
 -            public CommitLogSegment call()
 -            {
 -                return segment.recycle();
 -            }
 -        });
      }
  
      /**


[3/4] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

Posted by sn...@apache.org.
Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/10c65d43
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/10c65d43
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/10c65d43

Branch: refs/heads/trunk
Commit: 10c65d434c317b2c5462a3c2c428befd12986f7f
Parents: 56a06d7 20ce2cf
Author: Robert Stupp <sn...@snazy.de>
Authored: Sat Oct 17 11:38:38 2015 +0200
Committer: Robert Stupp <sn...@snazy.de>
Committed: Sat Oct 17 11:39:37 2015 +0200

----------------------------------------------------------------------
 CHANGES.txt                                             |  5 +++++
 .../cassandra/db/commitlog/CommitLogSegmentManager.java | 12 +++++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/10c65d43/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index 33c360e,889438f..9b86ebd
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,26 -1,15 +1,31 @@@
 -2.2.4
 - * Deprecate Pig support (CASSANDRA-10542)
 - * Reduce contention getting instances of CompositeType (CASSANDRA-10433)
++3.0
+ Merged from 2.1:
+  * AssertionError: attempted to delete non-existing file CommitLog (CASSANDRA-10377)
 - * (cqlsh) Distinguish negative and positive infinity in output (CASSANDRA-10523)
 - * (cqlsh) allow custom time_format for COPY TO (CASSANDRA-8970)
 - * Don't allow startup if the node's rack has changed (CASSANDRA-10242)
 - * (cqlsh) show partial trace if incomplete after max_trace_wait (CASSANDRA-7645)
+ 
+ 
 -2.2.3
 +3.0-rc2
 + * Fix SELECT DISTINCT queries between 2.2.2 nodes and 3.0 nodes (CASSANDRA-10473)
 + * Remove circular references in SegmentedFile (CASSANDRA-10543)
 + * Ensure validation of indexed values only occurs once per-partition (CASSANDRA-10536)
 + * Fix handling of static columns for range tombstones in thrift (CASSANDRA-10174)
 + * Support empty ColumnFilter for backward compatility on empty IN (CASSANDRA-10471)
 + * Remove Pig support (CASSANDRA-10542)
 + * Fix LogFile throws Exception when assertion is disabled (CASSANDRA-10522)
 + * Revert CASSANDRA-7486, make CMS default GC, move GC config to
 +   conf/jvm.options (CASSANDRA-10403)
 + * Fix TeeingAppender causing some logs to be truncated/empty (CASSANDRA-10447)
 + * Allow EACH_QUORUM for reads (CASSANDRA-9602)
 + * Fix potential ClassCastException while upgrading (CASSANDRA-10468)
 + * Fix NPE in MVs on update (CASSANDRA-10503)
 + * Only include modified cell data in indexing deltas (CASSANDRA-10438)
 + * Do not load keyspace when creating sstable writer (CASSANDRA-10443)
 + * If node is not yet gossiping write all MV updates to batchlog only (CASSANDRA-10413)
 + * Re-populate token metadata after commit log recovery (CASSANDRA-10293)
 + * Provide additional metrics for materialized views (CASSANDRA-10323)
 + * Flush system schema tables after local schema changes (CASSANDRA-10429)
 +Merged from 2.2:
 + * Reduce contention getting instances of CompositeType (CASSANDRA-10433)
 + * Fix the regression when using LIMIT with aggregates (CASSANDRA-10487)
   * Avoid NoClassDefFoundError during DataDescriptor initialization on windows (CASSANDRA-10412)
   * Preserve case of quoted Role & User names (CASSANDRA-10394)
   * cqlsh pg-style-strings broken (CASSANDRA-10484)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/10c65d43/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
----------------------------------------------------------------------