[GitHub] [incubator-druid] a2l007 commented on a change in pull request #8779: Handle missing values for delimited text files when Nullhandling is enabled

[GitBox <gi...@apache.org>]

a2l007 commented on a change in pull request #8779: Handle missing values for delimited text files when Nullhandling is enabled
URL: https://github.com/apache/incubator-druid/pull/8779#discussion_r341737549
 
 

 ##########
 File path: indexing-service/src/test/java/org/apache/druid/indexing/overlord/sampler/FirehoseSamplerTest.java
 ##########
 @@ -814,9 +814,7 @@ private ParseSpec getParseSpec(TimestampSpec timestampSpec, DimensionsSpec dimen
   private String getUnparseableTimestampString()
   {
     return ParserType.STR_CSV.equals(parserType)
-           ? (USE_DEFAULT_VALUE_FOR_NULL
-              ? "Unparseable timestamp found! Event: {t=bad_timestamp, dim1=foo, dim2=null, met1=6}"
-              : "Unparseable timestamp found! Event: {t=bad_timestamp, dim1=foo, dim2=, met1=6}")
+           ? "Unparseable timestamp found! Event: {t=bad_timestamp, dim1=foo, dim2=null, met1=6}"
 
 Review comment:
   @nishantmonu51 Please let me know if you think there is a better way to do this. 
   With the CSVParser fix in this PR, the way to specify empty values for csv files would be `''"`
   One of the test data samples is `bad_timestamp,foo,,6` and dim2 would be null regardless of whether null handling is enabled or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org