You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@archiva.apache.org by "Lars Beuster (JIRA)" <ji...@codehaus.org> on 2009/03/20 16:44:12 UTC

[jira] Created: (MRM-1149) White/Blacklist pattern matching doesn't work for Maven-1-repos

White/Blacklist pattern matching doesn't work for Maven-1-repos
---------------------------------------------------------------

                 Key: MRM-1149
                 URL: http://jira.codehaus.org/browse/MRM-1149
             Project: Archiva
          Issue Type: Bug
          Components: remote proxy
    Affects Versions: 1.2-M1
            Reporter: Lars Beuster


I have a proxy connector to a Maven-1 repo.
I have a whitelist entry "my/group/**".

If I try to download an artifact with the groupId "my.group.id" then my repository is ignored.

This is because for Maven-2 repos the resolved filename is something like "my/group/id/<artifactId>". 
But I have a Maven-1 repo and here the resolved filename is "my.group.id/<artifactId>".

Changing the whitelist entry to "my.group.**" still doesn't work, because the method DefaultRepositoryProxyConnector.matchesPattern() uses org.codehaus.plexus.util.SelectorUtils.matchPath() to check if the file matches a whitelist entry. 
But SelectorUtils works only with the "file.separator" ("/" on Unix) to split the filename. So I have no chance of using stars (*) in the whitelist. 

As a hack I could specify the complete groupId with stars (I cannot omit the stars) "my.group.id/**" - this works. But I can't add "my.group.**" to the whitelist.

Regards
Lars

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1149) White/Blacklist pattern matching doesn't work for Maven-1-repos

Posted by "Lars Beuster (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=170643#action_170643 ] 

Lars Beuster commented on MRM-1149:
-----------------------------------

Yes, this works, good idea - and a good workaround.

Thanks
Lars

> White/Blacklist pattern matching doesn't work for Maven-1-repos
> ---------------------------------------------------------------
>
>                 Key: MRM-1149
>                 URL: http://jira.codehaus.org/browse/MRM-1149
>             Project: Archiva
>          Issue Type: Bug
>          Components: remote proxy
>    Affects Versions: 1.2-M1
>            Reporter: Lars Beuster
>
> I have a proxy connector to a Maven-1 repo.
> I have a whitelist entry "my/group/**".
> If I try to download an artifact with the groupId "my.group.id" then my repository is ignored.
> This is because for Maven-2 repos the resolved filename is something like "my/group/id/<artifactId>". 
> But I have a Maven-1 repo and here the resolved filename is "my.group.id/<artifactId>".
> Changing the whitelist entry to "my.group.**" still doesn't work, because the method DefaultRepositoryProxyConnector.matchesPattern() uses org.codehaus.plexus.util.SelectorUtils.matchPath() to check if the file matches a whitelist entry. 
> But SelectorUtils works only with the "file.separator" ("/" on Unix) to split the filename. So I have no chance of using stars (*) in the whitelist. 
> As a hack I could specify the complete groupId with stars (I cannot omit the stars) "my.group.id/**" - this works. But I can't add "my.group.**" to the whitelist.
> Regards
> Lars

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1149) White/Blacklist pattern matching doesn't work for Maven-1-repos

Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maria Odea Ching updated MRM-1149:
----------------------------------

    Fix Version/s:     (was: 1.2.3)
                   1.3

> White/Blacklist pattern matching doesn't work for Maven-1-repos
> ---------------------------------------------------------------
>
>                 Key: MRM-1149
>                 URL: http://jira.codehaus.org/browse/MRM-1149
>             Project: Archiva
>          Issue Type: Bug
>          Components: remote proxy
>    Affects Versions: 1.2-M1
>            Reporter: Lars Beuster
>             Fix For: 1.3
>
>
> I have a proxy connector to a Maven-1 repo.
> I have a whitelist entry "my/group/**".
> If I try to download an artifact with the groupId "my.group.id" then my repository is ignored.
> This is because for Maven-2 repos the resolved filename is something like "my/group/id/<artifactId>". 
> But I have a Maven-1 repo and here the resolved filename is "my.group.id/<artifactId>".
> Changing the whitelist entry to "my.group.**" still doesn't work, because the method DefaultRepositoryProxyConnector.matchesPattern() uses org.codehaus.plexus.util.SelectorUtils.matchPath() to check if the file matches a whitelist entry. 
> But SelectorUtils works only with the "file.separator" ("/" on Unix) to split the filename. So I have no chance of using stars (*) in the whitelist. 
> As a hack I could specify the complete groupId with stars (I cannot omit the stars) "my.group.id/**" - this works. But I can't add "my.group.**" to the whitelist.
> Regards
> Lars

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1149) White/Blacklist pattern matching doesn't work for Maven-1-repos

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=176438#action_176438 ] 

Brett Porter commented on MRM-1149:
-----------------------------------

another alternative would be checking it against the incoming request in addition to the outgoing request

> White/Blacklist pattern matching doesn't work for Maven-1-repos
> ---------------------------------------------------------------
>
>                 Key: MRM-1149
>                 URL: http://jira.codehaus.org/browse/MRM-1149
>             Project: Archiva
>          Issue Type: Bug
>          Components: remote proxy
>    Affects Versions: 1.2-M1
>            Reporter: Lars Beuster
>             Fix For: 1.2.1
>
>
> I have a proxy connector to a Maven-1 repo.
> I have a whitelist entry "my/group/**".
> If I try to download an artifact with the groupId "my.group.id" then my repository is ignored.
> This is because for Maven-2 repos the resolved filename is something like "my/group/id/<artifactId>". 
> But I have a Maven-1 repo and here the resolved filename is "my.group.id/<artifactId>".
> Changing the whitelist entry to "my.group.**" still doesn't work, because the method DefaultRepositoryProxyConnector.matchesPattern() uses org.codehaus.plexus.util.SelectorUtils.matchPath() to check if the file matches a whitelist entry. 
> But SelectorUtils works only with the "file.separator" ("/" on Unix) to split the filename. So I have no chance of using stars (*) in the whitelist. 
> As a hack I could specify the complete groupId with stars (I cannot omit the stars) "my.group.id/**" - this works. But I can't add "my.group.**" to the whitelist.
> Regards
> Lars

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1149) White/Blacklist pattern matching doesn't work for Maven-1-repos

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MRM-1149:
------------------------------

    Fix Version/s: 1.2.1

will improve the documentation

> White/Blacklist pattern matching doesn't work for Maven-1-repos
> ---------------------------------------------------------------
>
>                 Key: MRM-1149
>                 URL: http://jira.codehaus.org/browse/MRM-1149
>             Project: Archiva
>          Issue Type: Bug
>          Components: remote proxy
>    Affects Versions: 1.2-M1
>            Reporter: Lars Beuster
>             Fix For: 1.2.1
>
>
> I have a proxy connector to a Maven-1 repo.
> I have a whitelist entry "my/group/**".
> If I try to download an artifact with the groupId "my.group.id" then my repository is ignored.
> This is because for Maven-2 repos the resolved filename is something like "my/group/id/<artifactId>". 
> But I have a Maven-1 repo and here the resolved filename is "my.group.id/<artifactId>".
> Changing the whitelist entry to "my.group.**" still doesn't work, because the method DefaultRepositoryProxyConnector.matchesPattern() uses org.codehaus.plexus.util.SelectorUtils.matchPath() to check if the file matches a whitelist entry. 
> But SelectorUtils works only with the "file.separator" ("/" on Unix) to split the filename. So I have no chance of using stars (*) in the whitelist. 
> As a hack I could specify the complete groupId with stars (I cannot omit the stars) "my.group.id/**" - this works. But I can't add "my.group.**" to the whitelist.
> Regards
> Lars

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1149) White/Blacklist pattern matching doesn't work for Maven-1-repos

Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maria Odea Ching updated MRM-1149:
----------------------------------

    Fix Version/s:     (was: 1.3)
                   1.3.1

> White/Blacklist pattern matching doesn't work for Maven-1-repos
> ---------------------------------------------------------------
>
>                 Key: MRM-1149
>                 URL: http://jira.codehaus.org/browse/MRM-1149
>             Project: Archiva
>          Issue Type: Bug
>          Components: remote proxy
>    Affects Versions: 1.2-M1
>            Reporter: Lars Beuster
>             Fix For: 1.3.1
>
>
> I have a proxy connector to a Maven-1 repo.
> I have a whitelist entry "my/group/**".
> If I try to download an artifact with the groupId "my.group.id" then my repository is ignored.
> This is because for Maven-2 repos the resolved filename is something like "my/group/id/<artifactId>". 
> But I have a Maven-1 repo and here the resolved filename is "my.group.id/<artifactId>".
> Changing the whitelist entry to "my.group.**" still doesn't work, because the method DefaultRepositoryProxyConnector.matchesPattern() uses org.codehaus.plexus.util.SelectorUtils.matchPath() to check if the file matches a whitelist entry. 
> But SelectorUtils works only with the "file.separator" ("/" on Unix) to split the filename. So I have no chance of using stars (*) in the whitelist. 
> As a hack I could specify the complete groupId with stars (I cannot omit the stars) "my.group.id/**" - this works. But I can't add "my.group.**" to the whitelist.
> Regards
> Lars

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1149) White/Blacklist pattern matching doesn't work for Maven-1-repos

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MRM-1149:
------------------------------

    Fix Version/s:     (was: 1.2.1)
                   1.2.2

> White/Blacklist pattern matching doesn't work for Maven-1-repos
> ---------------------------------------------------------------
>
>                 Key: MRM-1149
>                 URL: http://jira.codehaus.org/browse/MRM-1149
>             Project: Archiva
>          Issue Type: Bug
>          Components: remote proxy
>    Affects Versions: 1.2-M1
>            Reporter: Lars Beuster
>             Fix For: 1.2.2
>
>
> I have a proxy connector to a Maven-1 repo.
> I have a whitelist entry "my/group/**".
> If I try to download an artifact with the groupId "my.group.id" then my repository is ignored.
> This is because for Maven-2 repos the resolved filename is something like "my/group/id/<artifactId>". 
> But I have a Maven-1 repo and here the resolved filename is "my.group.id/<artifactId>".
> Changing the whitelist entry to "my.group.**" still doesn't work, because the method DefaultRepositoryProxyConnector.matchesPattern() uses org.codehaus.plexus.util.SelectorUtils.matchPath() to check if the file matches a whitelist entry. 
> But SelectorUtils works only with the "file.separator" ("/" on Unix) to split the filename. So I have no chance of using stars (*) in the whitelist. 
> As a hack I could specify the complete groupId with stars (I cannot omit the stars) "my.group.id/**" - this works. But I can't add "my.group.**" to the whitelist.
> Regards
> Lars

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1149) White/Blacklist pattern matching doesn't work for Maven-1-repos

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=170423#action_170423 ] 

Brett Porter commented on MRM-1149:
-----------------------------------

my.group.\*/\*\* for m1 (just one * in the group) is effectively the same as my/group/\*\* for m2 - does that work?

> White/Blacklist pattern matching doesn't work for Maven-1-repos
> ---------------------------------------------------------------
>
>                 Key: MRM-1149
>                 URL: http://jira.codehaus.org/browse/MRM-1149
>             Project: Archiva
>          Issue Type: Bug
>          Components: remote proxy
>    Affects Versions: 1.2-M1
>            Reporter: Lars Beuster
>
> I have a proxy connector to a Maven-1 repo.
> I have a whitelist entry "my/group/**".
> If I try to download an artifact with the groupId "my.group.id" then my repository is ignored.
> This is because for Maven-2 repos the resolved filename is something like "my/group/id/<artifactId>". 
> But I have a Maven-1 repo and here the resolved filename is "my.group.id/<artifactId>".
> Changing the whitelist entry to "my.group.**" still doesn't work, because the method DefaultRepositoryProxyConnector.matchesPattern() uses org.codehaus.plexus.util.SelectorUtils.matchPath() to check if the file matches a whitelist entry. 
> But SelectorUtils works only with the "file.separator" ("/" on Unix) to split the filename. So I have no chance of using stars (*) in the whitelist. 
> As a hack I could specify the complete groupId with stars (I cannot omit the stars) "my.group.id/**" - this works. But I can't add "my.group.**" to the whitelist.
> Regards
> Lars

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1149) White/Blacklist pattern matching doesn't work for Maven-1-repos

Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maria Odea Ching updated MRM-1149:
----------------------------------

    Fix Version/s:     (was: 1.2.2)
                   1.2.3

> White/Blacklist pattern matching doesn't work for Maven-1-repos
> ---------------------------------------------------------------
>
>                 Key: MRM-1149
>                 URL: http://jira.codehaus.org/browse/MRM-1149
>             Project: Archiva
>          Issue Type: Bug
>          Components: remote proxy
>    Affects Versions: 1.2-M1
>            Reporter: Lars Beuster
>             Fix For: 1.2.3
>
>
> I have a proxy connector to a Maven-1 repo.
> I have a whitelist entry "my/group/**".
> If I try to download an artifact with the groupId "my.group.id" then my repository is ignored.
> This is because for Maven-2 repos the resolved filename is something like "my/group/id/<artifactId>". 
> But I have a Maven-1 repo and here the resolved filename is "my.group.id/<artifactId>".
> Changing the whitelist entry to "my.group.**" still doesn't work, because the method DefaultRepositoryProxyConnector.matchesPattern() uses org.codehaus.plexus.util.SelectorUtils.matchPath() to check if the file matches a whitelist entry. 
> But SelectorUtils works only with the "file.separator" ("/" on Unix) to split the filename. So I have no chance of using stars (*) in the whitelist. 
> As a hack I could specify the complete groupId with stars (I cannot omit the stars) "my.group.id/**" - this works. But I can't add "my.group.**" to the whitelist.
> Regards
> Lars

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1149) White/Blacklist pattern matching doesn't work for Maven-1-repos

Posted by "Lars Beuster (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=170648#action_170648 ] 

Lars Beuster commented on MRM-1149:
-----------------------------------

Perhaps it's possible not only to improve the docs, but also to support the "my/group/\*\*"-syntax for m1-repos to have a more transparent view to the black-/whitelists.

> White/Blacklist pattern matching doesn't work for Maven-1-repos
> ---------------------------------------------------------------
>
>                 Key: MRM-1149
>                 URL: http://jira.codehaus.org/browse/MRM-1149
>             Project: Archiva
>          Issue Type: Bug
>          Components: remote proxy
>    Affects Versions: 1.2-M1
>            Reporter: Lars Beuster
>             Fix For: 1.2.1
>
>
> I have a proxy connector to a Maven-1 repo.
> I have a whitelist entry "my/group/**".
> If I try to download an artifact with the groupId "my.group.id" then my repository is ignored.
> This is because for Maven-2 repos the resolved filename is something like "my/group/id/<artifactId>". 
> But I have a Maven-1 repo and here the resolved filename is "my.group.id/<artifactId>".
> Changing the whitelist entry to "my.group.**" still doesn't work, because the method DefaultRepositoryProxyConnector.matchesPattern() uses org.codehaus.plexus.util.SelectorUtils.matchPath() to check if the file matches a whitelist entry. 
> But SelectorUtils works only with the "file.separator" ("/" on Unix) to split the filename. So I have no chance of using stars (*) in the whitelist. 
> As a hack I could specify the complete groupId with stars (I cannot omit the stars) "my.group.id/**" - this works. But I can't add "my.group.**" to the whitelist.
> Regards
> Lars

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira