You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yao Xu (Code Review)" <ge...@cloudera.org> on 2019/06/05 11:16:14 UTC
[kudu-CR] KUDU-2670 Set --enable rowset compactionlse flag for test of SplitKeyRange
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13517
Change subject: KUDU-2670 Set --enable_rowset_compaction=false flag for test of SplitKeyRange
......................................................................
KUDU-2670 Set --enable_rowset_compaction=false flag for test of SplitKeyRange
We found that in the SplitKeyRange related test, in most cases,
the number of KeyRange is equal to the number of tablets, but we
expect the number of KeyRange to be greater than the number of tablets.
This is beacuse rowset compact merges multiple DRSs into one, so
I added --enable_rowset_compaction=false ensure that the number of
KeyRange is greater than the number of tablets.
Change-Id: I89805a1fe2fd4d6c459e4abc0b1b9ec27c3e9588
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRange.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
2 files changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/13517/1
--
To view, visit http://gerrit.cloudera.org:8080/13517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89805a1fe2fd4d6c459e4abc0b1b9ec27c3e9588
Gerrit-Change-Number: 13517
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
[kudu-CR] KUDU-2670 Disable rowset compact for test of SplitKeyRange
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13517 )
Change subject: KUDU-2670 Disable rowset compact for test of SplitKeyRange
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89805a1fe2fd4d6c459e4abc0b1b9ec27c3e9588
Gerrit-Change-Number: 13517
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Jun 2019 04:55:25 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2670 Set --enable rowset compactionlse flag for test of SplitKeyRange
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13517 )
Change subject: KUDU-2670 Set --enable_rowset_compaction=false flag for test of SplitKeyRange
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13517/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRange.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRange.java:
http://gerrit.cloudera.org:8080/#/c/13517/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRange.java@45
PS1, Line 45: "--enable_rowset_compaction=false"
Doc the reason to set this in a comment just above it.
http://gerrit.cloudera.org:8080/#/c/13517/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala:
http://gerrit.cloudera.org:8080/#/c/13517/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@1033
PS1, Line 1033: "--enable_rowset_compaction=false"
Doc the reason to set this in a comment just above it.
--
To view, visit http://gerrit.cloudera.org:8080/13517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89805a1fe2fd4d6c459e4abc0b1b9ec27c3e9588
Gerrit-Change-Number: 13517
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 05 Jun 2019 22:04:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2670 Disable rowset compact for test of SplitKeyRange
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13517
to look at the new patch set (#2).
Change subject: KUDU-2670 Disable rowset compact for test of SplitKeyRange
......................................................................
KUDU-2670 Disable rowset compact for test of SplitKeyRange
We found that in the SplitKeyRange related test, in most cases,
the number of KeyRange is equal to the number of tablets, but we
expect the number of KeyRange to be greater than the number of tablets.
In the test, the DRS generated by flush MRS will be small, rowset
compact will merge them to a big one. This will reduce the number
of DRS in the tablet. If end up with only one DRS in the tablet,
then the tablet will only have one key range.
So, I added --enable_rowset_compaction=false to disable rowset compact,
ensure that the number of KeyRange is greater than the number of tablets.
Change-Id: I89805a1fe2fd4d6c459e4abc0b1b9ec27c3e9588
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRange.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
2 files changed, 13 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/13517/2
--
To view, visit http://gerrit.cloudera.org:8080/13517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I89805a1fe2fd4d6c459e4abc0b1b9ec27c3e9588
Gerrit-Change-Number: 13517
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2670 Disable rowset compact for test of SplitKeyRange
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13517 )
Change subject: KUDU-2670 Disable rowset compact for test of SplitKeyRange
......................................................................
KUDU-2670 Disable rowset compact for test of SplitKeyRange
We found that in the SplitKeyRange related test, in most cases,
the number of KeyRange is equal to the number of tablets, but we
expect the number of KeyRange to be greater than the number of tablets.
In the test, the DRS generated by flush MRS will be small, rowset
compact will merge them to a big one. This will reduce the number
of DRS in the tablet. If end up with only one DRS in the tablet,
then the tablet will only have one key range.
So, I added --enable_rowset_compaction=false to disable rowset compact,
ensure that the number of KeyRange is greater than the number of tablets.
Change-Id: I89805a1fe2fd4d6c459e4abc0b1b9ec27c3e9588
Reviewed-on: http://gerrit.cloudera.org:8080/13517
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRange.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
2 files changed, 13 insertions(+), 5 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89805a1fe2fd4d6c459e4abc0b1b9ec27c3e9588
Gerrit-Change-Number: 13517
Gerrit-PatchSet: 3
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)