[GitHub] [airflow] potiuk opened a new pull request #11835: Occasional docker-compose networks will be easier to diagnose

[GitBox <gi...@apache.org>]

potiuk opened a new pull request #11835:
URL: https://github.com/apache/airflow/pull/11835


   With this change we attempt to better diagnose some occasional
   network docker-compose issues that have beeen plaguing us after
   we solved or workarounded other CI-related issues. Sometimes
   the docker compose jobs fail on checking if the container is
   up and running with either of the two errors:
   
    * 'forward host lookup failed: Unknown host`
    * 'DNS fwd/rev mismatch'
   
   Usually this happens in rabbitMQ and openldap containers.
   
   Both indicate a problem with DNS of the docker engine or maybe
   some remnants of the previous docker run that do not allow us
   to start those containers.
   
   This change introduces few improvements:
   
   * added --volume in `docker system prune` command which might
     clean-up some anonymous volumes left by the containers between
     runs
   
   * removed docker-compose down --remove-orphans --down command
     after failure, as currently we are anyhow always doing it
     few lines before (before the test). This change will cause
     that our mechanism of logging container logs after failure
     will likely give us more information about in case the root
     cause is rabbitmq or openldap container failing to start
   
   * Increases number of tries to 5 in case of failed containers.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #11835: Occasional docker-compose errors will be easier to diagnose

[GitBox <gi...@apache.org>]

potiuk merged pull request #11835:
URL: https://github.com/apache/airflow/pull/11835


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #11835: Occasional docker-compose errors will be easier to diagnose

[GitBox <gi...@apache.org>]

potiuk commented on pull request #11835:
URL: https://github.com/apache/airflow/pull/11835#issuecomment-716482251


   Would love to get it in to see less failures from OpenLDAP hopefully :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org