[GitHub] [rocketmq] liyiwen3 opened a new issue #1630: Why can not ip of the broker listens start with "127.0" and "192.168"?If you want to get non-private address, ip that starts with "10." is private address

[GitBox <gi...@apache.org>]

liyiwen3 opened a new issue #1630: Why can not  ip of the broker listens start with "127.0" and "192.168"?If you want to get non-private address, ip that starts with "10." is private address
URL: https://github.com/apache/rocketmq/issues/1630
 
 
   why can not  ip that the broker listens start with "127.0" and "192.168"?  If you want to get non-private address, ip that starts with "10."  is private address. 
   
   code in RemotingUtil
   `public static String getLocalAddress() {
           try {
               // Traversal Network interface to get the first non-loopback and non-private address
               Enumeration<NetworkInterface> enumeration = NetworkInterface.getNetworkInterfaces();
               ArrayList<String> ipv4Result = new ArrayList<String>();
               ArrayList<String> ipv6Result = new ArrayList<String>();
               while (enumeration.hasMoreElements()) {
                   final NetworkInterface networkInterface = enumeration.nextElement();
                   final Enumeration<InetAddress> en = networkInterface.getInetAddresses();
                   while (en.hasMoreElements()) {
                       final InetAddress address = en.nextElement();
                       if (!address.isLoopbackAddress()) {
                           if (address instanceof Inet6Address) {
                               ipv6Result.add(normalizeHostAddress(address));
                           } else {
                               ipv4Result.add(normalizeHostAddress(address));
                           }
                       }
                   }
               }
   
               // prefer ipv4
               if (!ipv4Result.isEmpty()) {
                   for (String ip : ipv4Result) {
                       if (ip.startsWith("127.0") || ip.startsWith("192.168")) {
                           continue;
                       }
   
                       return ip;
                   }
   
                   return ipv4Result.get(ipv4Result.size() - 1);
               } else if (!ipv6Result.isEmpty()) {
                   return ipv6Result.get(0);
               }
               //If failed to find,fall back to localhost
               final InetAddress localHost = InetAddress.getLocalHost();
               return normalizeHostAddress(localHost);
           } catch (Exception e) {
               log.error("Failed to obtain local address", e);
           }
   
           return null;
       }`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services