You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/23 04:02:01 UTC
[GitHub] [kafka] feyman2016 opened a new pull request #10377: KAFKA-12515 [WIP] Update the ApiVersionManager
feyman2016 opened a new pull request #10377:
URL: https://github.com/apache/kafka/pull/10377
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #10377:
URL: https://github.com/apache/kafka/pull/10377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-864306447
@feyman2016 I think a patch to make supported and finalized features ignorable still has value. Sadly this has not been used yet, but I think it will be soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] feyman2016 commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
feyman2016 commented on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-805010605
Checked locally, test failure is not related~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] feyman2016 commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
feyman2016 commented on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-805459141
@abbccdda @kowshik Could you please help to review? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] feyman2016 commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
feyman2016 commented on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-864349950
> @feyman2016 I think a patch to make supported and finalized features ignorable still has value. Sadly this capability has not been used yet, but I think it will be soon.
@hachikuji Thanks for the feedback, I just updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] feyman2016 commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
feyman2016 commented on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-805562402
I need to double confirm the test failure is not related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji edited a comment on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
hachikuji edited a comment on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-864306447
@feyman2016 I think a patch to make supported and finalized features ignorable still has value. Sadly this capability has not been used yet, but I think it will be soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] feyman2016 edited a comment on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
feyman2016 edited a comment on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-805562402
Merged trunk and made another commit.
The failed test `kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()` doesn't seem to be related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] feyman2016 edited a comment on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
feyman2016 edited a comment on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-805562402
Merged trunk and made another commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rajinisivaram commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
rajinisivaram commented on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-847762942
@feyman2016 We should add `ignorable=true` for the fields added for feature support in `clients/src/main/resources/common/message/ApiVersionsResponse.json`. This would avoid having to pass the version around and set feature fields only if it is supported for the request/response version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] feyman2016 commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
feyman2016 commented on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-849526883
@rajinisivaram Thanks for the review, I will address it later~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #10377:
URL: https://github.com/apache/kafka/pull/10377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] feyman2016 commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
feyman2016 commented on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-821774667
Hi, I checked locally, all the failed tests should be unrelated:
```
Build / JDK 8 and Scala 2.12 / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() | 18 sec | 1
-- | -- | --
Build / JDK 15 and Scala 2.13 / org.apache.kafka.streams.integration.StoreQueryIntegrationTest.shouldQueryOnlyActivePartitionStoresByDefault | 10 sec | 1
Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication() | 2 min 13 sec | 1
Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplicationWithEmptyPartition() | 1 min 21 sec | 1
Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync() | 1 min 20 sec | 1
Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication() | 1 min 19 sec | 1
Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplicationWithEmptyPartition() | 1 min 25 sec | 1
Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] feyman2016 commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version
Posted by GitBox <gi...@apache.org>.
feyman2016 commented on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-860202376
@rajinisivaram Sorry for the late reply, I tried to set the `FinalizedFeatures` and `SupportedFeatures` to `"ignorable": true` and modified the `BrokerFeatures.createDefault()` as below, and the test won't complain now. But since the versioning scheme is not being used and `BrokerFeatures.createDefault()` is still empty now, I doubt the necessity for this PR, what do you think? (More background: The original purpose of this PR is KAFKA-9689, but now 9689 is on-hold.)
```
object BrokerFeatures extends Logging {
def createDefault(): BrokerFeatures = { val featureMap = Map("Sample" -> new SupportedVersionRange(1,3)).asJava
val supportedFeatures = Features.supportedFeatures(featureMap)
new BrokerFeatures(supportedFeatures)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org