[jira] [Created] (COLLECTIONS-802) ReferenceMap iterator remove may fail

["Ben Manes (Jira)" <ji...@apache.org>]

Ben Manes created COLLECTIONS-802:
-------------------------------------

             Summary: ReferenceMap iterator remove may fail
                 Key: COLLECTIONS-802
                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-802
             Project: Commons Collections
          Issue Type: Bug
          Components: Map
    Affects Versions: 4.4
            Reporter: Ben Manes
         Attachments: ApacheMapTest.java

Out of curiosity I ran Guava's testlib Map tests against the Apache types. This uncovered a contract bug {{remove()}} is invalidated by {{hasNext()}} so its call will no-op (currentKey is {{{}null{}}}). The isolates case is,
{code:java}
@Test
public void iterator_remove() {
  var map = new ReferenceMap<>();
  map.put(1, 2);
  var iter = map.entrySet().iterator();
  assertTrue(iter.hasNext());
  assertTrue(iter.hasNext());
  assertEquals(iter.next(), 1);
  assertFalse(iter.hasNext());
  iter.remove();
  assertEquals(map, Map.of());
}{code}
Guava's testlib has good coverage for the Collections Framework and might be worth integrating. The simple test case that I wrote is attached.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)