You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/13 15:01:25 UTC
[GitHub] [incubator-doris] morningman commented on a change in pull request
#3081: [Dynamic Partition] Support for automatically drop partitions
morningman commented on a change in pull request #3081: [Dynamic Partition] Support for automatically drop partitions
URL: https://github.com/apache/incubator-doris/pull/3081#discussion_r392275596
##########
File path: fe/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java
##########
@@ -136,12 +245,15 @@ private void dynamicAddPartition() {
iterator.remove();
continue;
}
- String tableName;
- ArrayList<AddPartitionClause> addPartitionClauses = new ArrayList<>();
+
db.readLock();
+ ArrayList<AddPartitionClause> addPartitionClauses;
+ ArrayList<DropPartitionClause> dropPartitionClauses;
+ OlapTable olapTable = (OlapTable) db.getTable(tableId);
+ String tableName;
+ boolean skipAddPartition = false;
Review comment:
the pattern should be:
```
db.readLock();
try {
OlapTable olapTable = (OlapTable) db.getTable(tableId);
.....
} finally {
db.readUnlock();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org