You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/01 01:45:13 UTC
[GitHub] [airflow] cra opened a new pull request, #26098: Add more weekday operator and sensor examples #26071
cra opened a new pull request, #26098:
URL: https://github.com/apache/airflow/pull/26098
Hello
This PR contains the following:
* adds more examples and explicit mention of imports of WeekDay enum in `BranchDayOfWeekOperator`.
* adds back reference to now-deprecated kwarg, mentions that you should not use it (I saw something similar in the docs for other deprecated params and would think it's a good idea to have it in the docs since it's in the constructor)
* adds more tasks in dag example for BranchDayOfWeekOperator so it's hopefully clearer on how to use WeekDay enum.
* **somewhat code-affecting change**: adds type hints for the weekday sensor. I also updated hints for the week_day so it has the enum in it
It all should add more examples to both HowTo for the operator and the operator/sensor description in the docs
closes: #26071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26098: Add more weekday operator and sensor examples #26071
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26098:
URL: https://github.com/apache/airflow/pull/26098#issuecomment-1241380677
Nice one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a diff in pull request #26098: Add more weekday operator and sensor examples #26071
Posted by GitBox <gi...@apache.org>.
kaxil commented on code in PR #26098:
URL: https://github.com/apache/airflow/pull/26098#discussion_r961162571
##########
airflow/sensors/weekday.py:
##########
@@ -66,13 +67,23 @@ class DayOfWeekSensor(BaseSensorOperator):
* ``{WeekDay.TUESDAY}``
* ``{WeekDay.SATURDAY, WeekDay.SUNDAY}``
+ To use `WeekDay` enum, import it from `airflow.utils.weekday`
Review Comment:
```suggestion
To use ``WeekDay`` enum, import it from ``airflow.utils.weekday``
```
since it is rst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26098: Add more weekday operator and sensor examples #26071
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #26098:
URL: https://github.com/apache/airflow/pull/26098#issuecomment-1241416020
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26098: Add more weekday operator and sensor examples #26071
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26098:
URL: https://github.com/apache/airflow/pull/26098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org