[GitHub] [ignite-3] rpuch commented on a diff in pull request #2412: IGNITE-20153 Prepare existing tests for the distributed zone to switch to the catalog

["rpuch (via GitHub)" <gi...@apache.org>]

rpuch commented on code in PR #2412:
URL: https://github.com/apache/ignite-3/pull/2412#discussion_r1284340635


##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerConfigurationChangesTest.java:
##########
@@ -172,18 +175,20 @@ public void setUp() throws Exception {
 
     @AfterEach
     public void tearDown() throws Exception {
-        distributionZoneManager.stop();
-        metaStorageManager.stop();
-        clusterCfgMgr.stop();
-        vaultMgr.stop();
-        generator.close();
+        IgniteUtils.closeAll(

Review Comment:
   It seems that if we switch to `closeAllManually()`, most of the null-checks will become obsolete



##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerTest.java:
##########
@@ -114,498 +100,17 @@ public void tearDown() throws Exception {
     }
 
     @Test
-    public void testCreateZoneWithAutoAdjust() throws Exception {

Review Comment:
   A lot of tests were removed. Aren't they needed anymore (if yes, why?), or they are moved to somewhere else?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org