You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "chenghuichen (via GitHub)" <gi...@apache.org> on 2025/02/17 06:22:40 UTC
[PR] #38 Expose More Metadata in Object APIs [paimon-python]
chenghuichen opened a new pull request, #39:
URL: https://github.com/apache/paimon-python/pull/39
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #38
<!-- What is the purpose of the change -->
Expose More Metadata in Object APIs, for the benefice for optimizing read/write strategies.
### Tests
<!-- List UT and IT cases to verify this change -->
- test_read_type_metadata
- test_split_metadata
### API and Format
<!-- Does this change affect API or storage format -->
Yes.
- add new object `RowType` with method `as_arrow`.
- add new methods `row_count`, `file_size`, `file_paths` to the object `Split`.
- and new method `read_type` to the object `ReadBuilder`, which following the design of java paimon.
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #38 Expose More Metadata in Object APIs [paimon-python]
Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin merged PR #39:
URL: https://github.com/apache/paimon-python/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #38 Expose More Metadata in Object APIs [paimon-python]
Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin commented on code in PR #39:
URL: https://github.com/apache/paimon-python/pull/39#discussion_r1961083426
##########
pypaimon/py4j/java_implementation.py:
##########
@@ -115,6 +115,18 @@ def new_read(self) -> 'TableRead':
def new_predicate_builder(self) -> 'PredicateBuilder':
return PredicateBuilder(self._j_row_type)
+ def read_type(self) -> 'RowType':
Review Comment:
Maybe we can return pa.schema directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #38 Expose More Metadata in Object APIs [paimon-python]
Posted by "chenghuichen (via GitHub)" <gi...@apache.org>.
chenghuichen commented on code in PR #39:
URL: https://github.com/apache/paimon-python/pull/39#discussion_r1961103002
##########
pypaimon/py4j/java_implementation.py:
##########
@@ -115,6 +115,18 @@ def new_read(self) -> 'TableRead':
def new_predicate_builder(self) -> 'PredicateBuilder':
return PredicateBuilder(self._j_row_type)
+ def read_type(self) -> 'RowType':
Review Comment:
For API's extensibility, peasonally I think this is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #38 Expose More Metadata in Object APIs [paimon-python]
Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin commented on PR #39:
URL: https://github.com/apache/paimon-python/pull/39#issuecomment-2667732296
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org