You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/09 08:58:39 UTC

[GitHub] [spark] cxzl25 opened a new pull request #25084: [SPARK-28314][SQL] Use the same MemoryManager when building HashedRelation

cxzl25 opened a new pull request #25084: [SPARK-28314][SQL] Use the same MemoryManager when building HashedRelation
URL: https://github.com/apache/spark/pull/25084
 
 
   ## What changes were proposed in this pull request?
   
   Broadcasting some tables with a large number of rows may cause infinite recursion loop in ```TaskMemoryManager#allocatePage```.
   This is because ```HashedRelation``` uses ```Long.MaxValue``` to construct ```MemoryManager``` instead of memory configured by driver.
   ```MemoryAllocator#allocate``` throws OOM,```TaskMemoryManager#allocatePage``` captures OOM and continues to call ```allocatePage```.
   
   ## How was this patch tested?
   add UT
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org