You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (Jira)" <ji...@apache.org> on 2019/09/21 02:00:00 UTC
[jira] [Commented] (HIVE-22221) Llap external client - Need to
reduce LlapBaseInputFormat#getSplits() footprint
[ https://issues.apache.org/jira/browse/HIVE-22221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934875#comment-16934875 ]
Hive QA commented on HIVE-22221:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 48s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 16s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 22s{color} | {color:blue} llap-client in master has 26 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 4s{color} | {color:blue} ql in master has 1571 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 24s{color} | {color:blue} llap-ext-client in master has 1 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 37s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 10s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 40s{color} | {color:red} ql: The patch generated 49 new + 96 unchanged - 4 fixed = 145 total (was 100) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 10s{color} | {color:red} llap-ext-client: The patch generated 3 new + 36 unchanged - 2 fixed = 39 total (was 38) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} itests/hive-unit: The patch generated 9 new + 53 unchanged - 5 fixed = 62 total (was 58) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 32s{color} | {color:red} llap-client generated 1 new + 26 unchanged - 0 fixed = 27 total (was 26) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 12s{color} | {color:red} ql generated 1 new + 1570 unchanged - 1 fixed = 1571 total (was 1571) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 33s{color} | {color:red} llap-ext-client generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 54s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:llap-client |
| | org.apache.hadoop.hive.llap.LlapInputSplit.setPlanBytes(byte[]) may expose internal representation by storing an externally mutable object into LlapInputSplit.planBytes At LlapInputSplit.java:by storing an externally mutable object into LlapInputSplit.planBytes At LlapInputSplit.java:[line 95] |
| FindBugs | module:ql |
| | Redundant nullcheck of driverCleanup, which is known to be non-null in org.apache.hadoop.hive.ql.udf.generic.GenericUDTFGetSplits.createPlanFragment(String, ApplicationId) Redundant null check at GenericUDTFGetSplits.java:is known to be non-null in org.apache.hadoop.hive.ql.udf.generic.GenericUDTFGetSplits.createPlanFragment(String, ApplicationId) Redundant null check at GenericUDTFGetSplits.java:[line 400] |
| FindBugs | module:llap-ext-client |
| | Exception is caught when Exception is not thrown in org.apache.hadoop.hive.llap.LlapBaseInputFormat.getSplits(JobConf, int) At LlapBaseInputFormat.java:is not thrown in org.apache.hadoop.hive.llap.LlapBaseInputFormat.getSplits(JobConf, int) At LlapBaseInputFormat.java:[line 324] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18672/dev-support/hive-personality.sh |
| git revision | master / 1278bf1 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18672/yetus/diff-checkstyle-ql.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18672/yetus/diff-checkstyle-llap-ext-client.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18672/yetus/diff-checkstyle-itests_hive-unit.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-18672/yetus/new-findbugs-llap-client.html |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-18672/yetus/new-findbugs-ql.html |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-18672/yetus/new-findbugs-llap-ext-client.html |
| modules | C: llap-client ql llap-ext-client itests/hive-unit U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18672/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Llap external client - Need to reduce LlapBaseInputFormat#getSplits() footprint
> ---------------------------------------------------------------------------------
>
> Key: HIVE-22221
> URL: https://issues.apache.org/jira/browse/HIVE-22221
> Project: Hive
> Issue Type: Bug
> Components: llap, UDF
> Reporter: Shubham Chaurasia
> Assignee: Shubham Chaurasia
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22221.1.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While querying through llap external client, LlapBaseInputFormat#getSplits() invokes get_splits() (GenericUDTFGetSplits) udtf under the hoods.
> GenericUDTFGetSplits returns LlapInputSplit in which planBytes[] occupies around 90% of the split size.
> Depending on data size/partitions and plan, LlapInputSplit can grow upto 1mb with planBytes[] being common to all the splits and occupying more than 850 kb. Also, it sometimes causes OOM on HS2 depending on HS2 heap size.
> This can be resolved by separating out common parts from actual splits and reassembling them at client side.
> We can also provide an option where client can say it does not want to reassemble them and can take the control of reassembling in it's hands.
> Splits can be broken like:
> 1) schema split
> 2) plan split
> 3) actual split 1
> 4) actual split 2....and so on.
> This greatly reduces the memory(in my case from 5GB(~5000 splits) to around 15MB) on server side and hence the data transfer. And this eliminates OOM on HS2 side.
> cc [~jdere] [~sankarh] [~thejas]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)