[jira] [Commented] (IMPALA-13413) num_cores flag does not work.

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-13413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18051745#comment-18051745 ] 

ASF subversion and git services commented on IMPALA-13413:
----------------------------------------------------------

Commit adbab4d5ae0e7857c8593258e5eab07445bfdd6a in impala's branch refs/heads/master from Yubi Lee
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=adbab4d5a ]

IMPALA-13413: fix ignored num_cores flag

Previously, CpuInfo::Init() was called before ParseCommandLineFlags(),
so FLAGS_num_cores was always 0, making the --num_cores flag ignored.

Change-Id: I72454d74ccf8c5110c59f923cef4caf434e2fba7
Reviewed-on: http://gerrit.cloudera.org:8080/23333
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> num_cores flag does not work.
> -----------------------------
>
>                 Key: IMPALA-13413
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13413
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 4.4.1
>            Reporter: Yonghwan Lee
>            Assignee: YUBI LEE
>            Priority: Minor
>
> The `num_cores` Flag does not work.
>  
> The cause is that CpuInfo::Init() is called before google::ParseCommandLineFlags(&argc, &argv, true) within the InitCommonRuntime function in init.cc.
>  
> Other functions (e.g. DiskInfo, MemInfo, etc.) do not use the value (Gflag) parsed from the CommandLine in the Init() function, but in the case of CpuInfo, FLAGS_num_cores is used within Init().
> Since google::ParseCommandLineFlags(&argc, &argv, true) has not yet been called, its value is set to 0, and if (FLAGS_num_cores > 0) num_cores_ = FLAGS_num_cores; It is confirmed that the syntax does not work.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org