[GitHub] [phoenix] gjacoby126 commented on a change in pull request #1299: PHOENIX-6540 Drop Hbase 1.3 support from 4.x branch

[GitBox <gi...@apache.org>]

gjacoby126 commented on a change in pull request #1299:
URL: https://github.com/apache/phoenix/pull/1299#discussion_r705767190



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
##########
@@ -109,20 +109,20 @@ private void snapshotAllMetrics(MetricRegistry metricRegistry,
             Map<String, Metric> metrics = metricRegistry.getMetrics();
             Iterator iterator = metrics.entrySet().iterator();
 
-            while (iterator.hasNext()) {
-                Entry<String, Metric> e = (Entry) iterator.next();
+            while(iterator.hasNext()) {
+                Entry<String, Metric> e = (Entry)iterator.next();

Review comment:
       tiny nit: the extra space between casted class and variable aids readability (and removing the space it makes this patch larger). I believe our checkstyle wants the space too, iirc




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org