You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2014/12/19 00:00:18 UTC

Review Request 29222: Kerberos Wizard -> Configure Identities page: Show properties for only installed services

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29222/
-----------------------------------------------------------

Review request for Ambari, Xi Wang and Yusaku Sako.


Bugs: AMBARI-8802
    https://issues.apache.org/jira/browse/AMBARI-8802


Repository: ambari


Description
-------

Currently UI surfacing entire stack descriptor. This fix adds the logic to show only installed services config on UI. (Although still entire composite kerberos descriptor will be saved)


Diffs
-----

  ambari-web/app/controllers/main/admin/kerberos/step4_controller.js 53ff138 
  ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 4bced94 

Diff: https://reviews.apache.org/r/29222/diff/


Testing
-------


Thanks,

Jaimin Jetly


Re: Review Request 29222: Kerberos Wizard -> Configure Identities page: Show properties for only installed services

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29222/#review65558
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Dec. 18, 2014, 11:02 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29222/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2014, 11:02 p.m.)
> 
> 
> Review request for Ambari, Xi Wang and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8802
>     https://issues.apache.org/jira/browse/AMBARI-8802
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently UI surfacing entire stack descriptor. This fix adds the logic to show only installed services config on UI. (Although still entire composite kerberos descriptor will be saved)
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/kerberos/step4_controller.js 53ff138 
>   ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 4bced94 
> 
> Diff: https://reviews.apache.org/r/29222/diff/
> 
> 
> Testing
> -------
> 
>   **ambari-web unit test result with the patch**
>   5297 tests complete (8 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 29222: Kerberos Wizard -> Configure Identities page: Show properties for only installed services

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29222/
-----------------------------------------------------------

(Updated Dec. 18, 2014, 11:02 p.m.)


Review request for Ambari, Xi Wang and Yusaku Sako.


Bugs: AMBARI-8802
    https://issues.apache.org/jira/browse/AMBARI-8802


Repository: ambari


Description
-------

Currently UI surfacing entire stack descriptor. This fix adds the logic to show only installed services config on UI. (Although still entire composite kerberos descriptor will be saved)


Diffs
-----

  ambari-web/app/controllers/main/admin/kerberos/step4_controller.js 53ff138 
  ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 4bced94 

Diff: https://reviews.apache.org/r/29222/diff/


Testing (updated)
-------

  **ambari-web unit test result with the patch**
  5297 tests complete (8 seconds)
  60 tests pending


Thanks,

Jaimin Jetly