[jira] [Comment Edited] (JCR-4475) Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path mapping

["Woonsan Ko (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919715#comment-16919715 ] 

Woonsan Ko edited comment on JCR-4475 at 8/30/19 4:47 PM:
----------------------------------------------------------

Yes, it changes the default servlet path mapping from "/*" to "/server/*", while giving an option to set it to empty one (the test case #2 above).
I thought the change would be better because that's how it is packaged and configured by default even in Jackrabbit-standalone. ;-)

BTW, we can possibly change the line like this to set the default servlet path to empty like before:
{code}
    private static final String WEBDAV_SERVLET_PATH_PREFIX = System.getProperty("WebDAVServletPrefix", "");
{code}



was (Author: woon_san):
Yes, it changes the default servlet path mapping from "/*" to "/server/*", while giving an option to set it to empty one (the test case #2 above).
I thought the change would be better because that's how it is packaged and configured by default even in Jackrabbit-standalone. ;-)

> Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path mapping
> ---------------------------------------------------------------------------------
>
>                 Key: JCR-4475
>                 URL: https://issues.apache.org/jira/browse/JCR-4475
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>    Affects Versions: 2.18.3
>            Reporter: Woonsan Ko
>            Assignee: Julian Reschke
>            Priority: Major
>             Fix For: 2.20
>
>         Attachments: servlet_path_prefix.patch
>
>
> {{org.apache.jackrabbit.jcr2dav.RepositoryStubImpl}} supports testing with custom context path like the following, but not with custom servlet path mapping.
> {noformat}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> It would be nice if we can test with custom servlet path mapping as well, instead of the hard-coded "/server" path only, like the following examples:
> {noformat:title=1. Default with /server prefix}
> $ mvn clean install -PintegrationTesting
> {noformat}
> {noformat:title=2. With empty servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix=""
> {noformat}
> {noformat:title=3. With custom servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix="/jcrserver"
> {noformat}
> {noformat:title=4. With custom context path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> {noformat:title=5. With custom context path and custom servlet path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo" -DWebDAVServletPrefix="/jcrserver"
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)