You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/09 05:34:05 UTC
[GitHub] [apisix] spacewander opened a new pull request #4014: fix(prometheus): collect nginx_status and return the body
spacewander opened a new pull request #4014:
URL: https://github.com/apache/apisix/pull/4014
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4014: fix(prometheus): collect nginx_status and return the body
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4014:
URL: https://github.com/apache/apisix/pull/4014#discussion_r610380177
##########
File path: t/cli/test_prometheus.sh
##########
@@ -35,6 +35,11 @@ if [ ! $code -eq 200 ]; then
exit 1
fi
+if ! curl -i http://127.0.0.1:9091/apisix/prometheus/metrics | grep "apisix_nginx_http_current_connections" > /dev/null; then
+ echo "failed: should listen default prometheus address"
+ exit 1
+fi
+
make stop
echo "passed: should listen default prometheus address"
Review comment:
@jbampton
Applied. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jbampton commented on a change in pull request #4014: fix(prometheus): collect nginx_status and return the body
Posted by GitBox <gi...@apache.org>.
jbampton commented on a change in pull request #4014:
URL: https://github.com/apache/apisix/pull/4014#discussion_r610359798
##########
File path: t/cli/test_prometheus.sh
##########
@@ -35,6 +35,11 @@ if [ ! $code -eq 200 ]; then
exit 1
fi
+if ! curl -i http://127.0.0.1:9091/apisix/prometheus/metrics | grep "apisix_nginx_http_current_connections" > /dev/null; then
+ echo "failed: should listen default prometheus address"
Review comment:
```suggestion
echo "failed: should listen at default prometheus address"
```
##########
File path: t/cli/test_prometheus.sh
##########
@@ -35,6 +35,11 @@ if [ ! $code -eq 200 ]; then
exit 1
fi
+if ! curl -i http://127.0.0.1:9091/apisix/prometheus/metrics | grep "apisix_nginx_http_current_connections" > /dev/null; then
+ echo "failed: should listen default prometheus address"
+ exit 1
+fi
+
make stop
echo "passed: should listen default prometheus address"
Review comment:
```suggestion
echo "passed: should listen at default prometheus address"
```
##########
File path: t/cli/test_prometheus.sh
##########
@@ -35,6 +35,11 @@ if [ ! $code -eq 200 ]; then
exit 1
fi
+if ! curl -i http://127.0.0.1:9091/apisix/prometheus/metrics | grep "apisix_nginx_http_current_connections" > /dev/null; then
+ echo "failed: should listen default prometheus address"
+ exit 1
+fi
+
make stop
echo "passed: should listen default prometheus address"
Review comment:
Some more in this file further down I think should be the same for better grammar like for:
`should listen at ....`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu merged pull request #4014: fix(prometheus): collect nginx_status and return the body
Posted by GitBox <gi...@apache.org>.
Yiyiyimu merged pull request #4014:
URL: https://github.com/apache/apisix/pull/4014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org