[GitHub] [incubator-kyuubi] deadwind4 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage

[GitBox <gi...@apache.org>]

deadwind4 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836013883



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
     newOutput += ""
     newOutput += ("Please refer to the Spark official online documentation for" +
       " [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+    newOutput += ""
+
+    newOutput += ("## Flink Configurations")
+    newOutput += ""
 
+    newOutput += ("### Via flink-conf.yaml")
     newOutput += ""
+    newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+      " supplies with default values for SQL engine application." +
+      " Available properties can be found at Flink official online documentation for" +
+      " [Flink Configurations]" +
+      "(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")

Review comment:
       As the Flink version is updated too fast, I prefer to use nightlies/master docs.  And users can jump low version in master docs, but the inverse is not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org